Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Minimise permissions when not needed. #2220

Merged
merged 11 commits into from
May 2, 2024
Merged

chore: Minimise permissions when not needed. #2220

merged 11 commits into from
May 2, 2024

Conversation

marcosuma
Copy link
Collaborator

Description

Please include a summary of the fix/feature/change, including any relevant motivation and context.

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@marcosuma marcosuma marked this pull request as ready for review May 2, 2024 06:23
@marcosuma marcosuma requested a review from a team as a code owner May 2, 2024 06:23
@marcosuma marcosuma merged commit e9b0ca0 into master May 2, 2024
32 checks passed
@marcosuma marcosuma deleted the CLOUDP-246014-policies branch May 2, 2024 13:37
lantoli added a commit that referenced this pull request May 3, 2024
@lantoli
Merge branch 'master' into CLOUDP-237334-rebase
2ccff26 
* master:
  chore: Minimise permissions when not needed. (#2220)
  chore: Bump github.com/aws/aws-sdk-go from 1.51.27 to 1.51.32 (#2225)
  chore: Bump crazy-max/ghaction-import-gpg from 2 to 6 (#2227)
  chore: Bump tj-actions/verify-changed-files (#2229)
  chore: Bump actions/checkout from 4.1.2 to 4.1.4 (#2228)
  chore: Bump peter-evans/create-pull-request from 6.0.4 to 6.0.5 (#2230)
  chore: Bump hashicorp/setup-terraform from 3.0.0 to 3.1.0 (#2231)
  chore: Tries to reduce OUT_OF_CAPACITY during tests by moving cluster creation to other cloud providers (#2206)
  fix: Fixes push-based log export migration tests (#2224)
  chore: Updates CHANGELOG.md for #2221
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maastha maastha maastha approved these changes

@lantoli lantoli lantoli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcosuma @lantoli @maastha