-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(NODE-5446): update driver v6 dependencies #3801
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: how come we decided to disable ban-types
in most of our lint configurations?
"eslint-plugin-import": "^2.27.5", | ||
"eslint": "^8.46.0", | ||
"eslint-config-prettier": "^8.10.0", | ||
"eslint-plugin-import": "^2.28.0", | ||
"eslint-plugin-prettier": "^4.2.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did we decide not to bump gcp-metadata?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, my bad, I missed updating that one.
@baileympearson re disabling ban-types, when updating the eslint and associated dev dependencies, we start getting the following lint failures
I wasn't sure if we wanted to address those here with code changes, so I disabled that rule, which in retrospect might have been a reach too far. I can disable the rule on a per-line basis and file a follow-up ticket. |
This reverts commit fd9a467.
Description
What is changing?
Update the following dev dependencies
Is there new documentation needed for these changes?
No
What is the motivation for this change?
NODE-5446; keeping tooling up to date
Release Highlight
Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript