Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps(NODE-5446): bump dependencies again for v6 #3860

Merged
merged 19 commits into from
Sep 13, 2023

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Sep 6, 2023

Description

In an interesting twist, upgrading dev dependencies again...no longer causes our aws tests to fail? 🤔

This PR basically updates all the dependencies Warren updated as a part of #3801. There are a few version differences (which could explain why the tests pass here but failed on Warren's initial PR). The aws tests pass consistently for me - I've run them 4 times now with none of the failures we saw on the initial dependency bump. I'm inclined to call this work "resolved", since I don't think it's worthwhile investigating why the dependency bump initially caused tests to fail if they pass consistently now.

This work includes a temporary fix to the npm version issues. We can either block this on Durran's CI fixes or just merge this and have Durran remove it when he implements the permanent fix.

What is changing?

Bumps the dependencies originally updated in #3801.

Is there new documentation needed for these changes?

What is the motivation for this change?

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson marked this pull request as ready for review September 6, 2023 22:39
@baileympearson baileympearson changed the title pin to npm 9 for now deps(NODE-5446): bump dependencies again for v6 Sep 6, 2023
@durran durran self-assigned this Sep 12, 2023
@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Sep 12, 2023
Copy link
Member

@durran durran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to resolve the npm fix conflicts.

@durran durran added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Sep 13, 2023
@durran durran merged commit 5b9fafd into main Sep 13, 2023
1 check passed
@durran durran deleted the repro-update-dependencies-issues-real branch September 13, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants