-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps(NODE-5446): bump dependencies again for v6 #3860
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 99ffcc5.
baileympearson
changed the title
pin to npm 9 for now
deps(NODE-5446): bump dependencies again for v6
Sep 6, 2023
durran
added
the
Primary Review
In Review with primary reviewer, not yet ready for team's eyes
label
Sep 12, 2023
durran
requested changes
Sep 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need to resolve the npm fix conflicts.
durran
added
Team Review
Needs review from team
and removed
Primary Review
In Review with primary reviewer, not yet ready for team's eyes
labels
Sep 13, 2023
durran
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In an interesting twist, upgrading dev dependencies again...no longer causes our aws tests to fail? 🤔
This PR basically updates all the dependencies Warren updated as a part of #3801. There are a few version differences (which could explain why the tests pass here but failed on Warren's initial PR). The aws tests pass consistently for me - I've run them 4 times now with none of the failures we saw on the initial dependency bump. I'm inclined to call this work "resolved", since I don't think it's worthwhile investigating why the dependency bump initially caused tests to fail if they pass consistently now.
This work includes a temporary fix to the
npm
version issues. We can either block this on Durran's CI fixes or just merge this and have Durran remove it when he implements the permanent fix.What is changing?
Bumps the dependencies originally updated in #3801.
Is there new documentation needed for these changes?
What is the motivation for this change?
Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript