Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(NODE-5446): revert bump dev dependencies (#3801) #3829

Merged
merged 1 commit into from
Aug 21, 2023
Merged

ci(NODE-5446): revert bump dev dependencies (#3801) #3829

merged 1 commit into from
Aug 21, 2023

Conversation

baileympearson
Copy link
Contributor

This reverts commit fd9a467.

Description

What is changing?

Is there new documentation needed for these changes?

What is the motivation for this change?

Release Highlight

Fill in title or leave empty for no highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson changed the title Revert "chore(NODE-5446): bump dev dependencies (#3801)" ci(NODE-5446): revert bump dev dependencies (#3801) Aug 21, 2023
@baileympearson baileympearson marked this pull request as ready for review August 21, 2023 15:28
nbbeeken
nbbeeken approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine to leave as is, however, the lint fixes are still worth keeping ban-types should have always been complaining about our use of Function

@baileympearson baileympearson merged commit a7ffdf5 into main Aug 21, 2023
1 check passed
@baileympearson baileympearson deleted the no-story-revert-dependency-bump branch August 21, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbbeeken nbbeeken nbbeeken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baileympearson @nbbeeken