-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
depends: boost: update to 1.84.0 #9162
base: master
Are you sure you want to change the base?
Conversation
tobtoht
commented
Feb 12, 2024
•
edited
Loading
edited
- Context for this PR: https://libera.monerologs.net/monero-dev/20240210#c331216
- Relevant for Add support for upcoming Boost 1.87.0 (Boost.Asio removals) #9596
- Needs depends: release type should be lower case #9457 to pass CI
@selsta Should we update the minimum Boost required? The Boost release notes list new libraries with each release. We currently list 1.58 as minimum. Bumping the minimum required allows us to use some newer libraries. The most interesting libraries are: Boost.Hana (1.61), Boost.Fiber ("green" threads)(1.62), Stacktrace (1.65), Beast (http parsing)(1.66), Boost.Mp11 (1.66), Boost.Outcome (1.70), Boost.Json (1.75), and Boost.Url (1.81). The Boost versions:
I would recommend Boost 1.66 based on this list (does not include Centos, which is not listed in current documentation). |
I think quite a few people still use Ubuntu 18.04 which seems to have boost 1.65, so I'd prefer nothing newer if possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine. I believe the failing tests are unrelated.