-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build with boost ASIO 1.87. Support boost 1.66+ #9628
base: master
Are you sure you want to change the base?
Conversation
(This needs #9162 to pass depends CI. I will undraft that PR after the next round of merges.) |
8c98c45
to
e88e61d
Compare
The latest force push should work with Boost 1.66-1.87. Something funky happened with the tests, so I may push a dummy change later to see what happens. |
https://github.com/tobtoht/monero/actions/runs/12390979989/job/34587144842#step:5:1281 Looks like |
e88e61d
to
f185187
Compare
Fore pushed some changes:
|
1c62d08
to
da62d98
Compare
Force pushed twice with updates:
|
da62d98
to
a0ce1e9
Compare
Force pushed an include fix. |
This patch looks ready. The depends CI will all fail until #9162 gets merged. I will leave as draft for now for that reason. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
README needs an update to indicate the new minimum version
Once this is ready for review, please remove Draft status. |
625f370
to
0452910
Compare
Force pushed:
Likely this will get removed as draft, assuming some of the tests cycle green. |
0452910
to
ad7eaaa
Compare
Forgot to update this in the last force push, so another quick push with this change. |
Now ready for review. |
This should compile with Boost 1.73-1.87. I have only tested on Boost 1.74 and Boost 1.87 (primarily unit tests). I will mark the places where I know changes need to be made for older boost versions. I will clear up all such errors by manually downloading Boost 1.66 and testing.
One problem I have with supporting Boost 1.66-1.69 is that most types require an io_context object, whereas Boost 1.70+ have relaxed this requirement to an executor object. I will show an example of where it matters; it will be easy to break older Boost versions unintentionally.
EDIT:
This is currently marked as a draft, because the depends build will fail until #9162 gets merged (which is also marked as draft).