depends: android_ndk: update to 18b #9182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would like to request a new "build system" tag for (future) PRs that touch contrib/{depends,gitian,guix} or CMakeLists.txt |
I agree. We do have "cmake" tag, but for this kind of PR that does not cmake, and related to build system, I am always worried to assign a tag. I will ask core about this. Thanks. |
jeffro256
reviewed
Feb 19, 2024
There was a problem hiding this comment.
I can confirm that building https://github.com/UkoeHB/monero/tree/seraphis_lib for Android ARMv8 doesn't work before this commit, but does work after this commit. Excellent work!
selsta
approved these changes
Feb 20, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting this out of #9162, since it also resolves an Android depends build issue here: seraphis-migration#16.
See related CI run: https://github.com/tobtoht/monero/commits/pr-16/