chore: tweaks to CI jobs to account for symlink refactor #370
+12
−11,413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cprice404
force-pushed
the
tweak-ci-for-symlink
branch
from
efa599f to
63c1c67
Compare
…symlink This commit removes all of the package.json and ts config files from the common dir since we are not treating it as a package, but rather just as a directory of files that will be shared via symlink between the SDKs. We also need to do a hacky thing for now in the build script, where we symlink the node_modules dir from the sdk into the common dir so that imports from the files in common will work. This won't be an issue for the packaged artifact since the symlink won't exist. In a subsequent commit we still need to add a solution for running the shared tests in the common directory.
cprice404
commented
Mar 23, 2023
| # this is gross, but npm will fail to import things | ||
| # during local builds of files in common if it doesn't | ||
| # find a node_modules directory there. | ||
| ln -s $(pwd)/node_modules ../common/node_modules |
There was a problem hiding this comment.
@bruuuuuuuce this is a hack that we might be able to find a better solution for in the future, but it should work for now. You will need to make sure you run this script to create this symlink for grpc-web sdk when you are using that path.
cprice404
added a commit
that referenced
this pull request
Mar 24, 2023
This reverts commit d85854c.
This was referenced Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.