chore: tweaks to CI jobs to account for symlink refactor (#370)

* chore: remove package files for common, fix imports via node_modules symlink

This commit removes all of the package.json and ts config files
from the common dir since we are not treating it as a package, but
rather just as a directory of files that will be shared via symlink
between the SDKs.

We also need to do a hacky thing for now in the build script, where
we symlink the node_modules dir from the sdk into the common dir
so that imports from the files in common will work.  This won't be
an issue for the packaged artifact since the symlink won't exist.

In a subsequent commit we still need to add a solution for running
the shared tests in the common directory.

.github/workflows/build.yml

@@ -44,18 +44,13 @@ jobs:
         with:
           node-version: ${{ matrix.node }}
 
-      # TODO: eventually we will have to add build steps for the grpc-web sdk
-      - name: Build Common Package
-        run: |
-          node -v
-          ./scripts/build-and-test-package.sh "common"
-
-      # needs to happen after building our common package, since it depends on it
       - name: Build nodejs sdk
         run: |
           node -v
           ./scripts/build-and-test-package.sh "client-sdk-nodejs"
 
+      # TODO: eventually we will have to add build steps for the grpc-web sdk
+
   test-examples:
     strategy:
       matrix:

.github/workflows/codeql.yml

@@ -52,19 +52,13 @@ jobs:
         # Details on CodeQL's query packs refer to : https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/configuring-code-scanning#using-queries-in-ql-packs
         # queries: security-extended,security-and-quality
 
-
-    # TODO: eventually we will have to add build steps for the grpc-web sdk
-    - name: Build Common Package
-      run: |
-        node -v
-        ./scripts/build-package.sh "common"
-
-    # needs to happen after building our common package, since it depends on it
     - name: Build nodejs sdk
       run: |
         node -v
         ./scripts/build-package.sh "client-sdk-nodejs"
 
+    # TODO: eventually we will have to add build steps for the grpc-web sdk
+
     # ℹ️ Command-line programs to run using the OS shell.
     # 📚 See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsrun
 

.github/workflows/on-push-to-main-branch.yml

@@ -22,18 +22,13 @@ jobs:
         with:
           node-version: 16
 
-      # TODO: eventually we will have to add build steps for the grpc-web sdk
-      - name: Build Common Package
-        run: |
-          node -v
-          ./scripts/build-package.sh "common"
-
-      # needs to happen after building our common package, since it depends on it
       - name: Build nodejs sdk
         run: |
           node -v
           ./scripts/build-package.sh "client-sdk-nodejs"
 
+      # TODO: eventually we will have to add build steps for the grpc-web sdk
+
       - name: Generate README
         uses: momentohq/standards-and-practices/github-actions/generate-and-commit-oss-readme@gh-actions-v1
         with:

.github/workflows/on-push-to-release-branch.yml

@@ -48,18 +48,14 @@ jobs:
           node-version: 16
           registry-url: 'https://registry.npmjs.org'
 
-      # TODO: eventually we will have to add build steps for the grpc-web sdk
-      - name: Build Common Package
-        run: |
-          node -v
-          ./scripts/build-package.sh "common"
 
-      # needs to happen after building our common package, since it depends on it
       - name: Build nodejs sdk
         run: |
           node -v
           ./scripts/build-package.sh "client-sdk-nodejs"
 
+      # TODO: eventually we will have to add build steps for the grpc-web sdk
+
       - name: Publish nodejs sdk package to npm
         run: |
           pushd ./packages/client-sdk-nodejs