Fix iOS landscape mode

[bartekpacia]

Proposed changes

Aims to fix #565 by mapping coordinates according to current simulator orientation.

Testing

Tested locally.

I would like to have automated tests as well, but not sure yet how to go about it.

[bartekpacia]

I think I got it working:

demorec.mp4

Current limitations:

• breaks if orientation is changed during flow execution

• breaks when simulator is in landscape, but app is portrait. This worked before these changes.

  Details

  demobug.mp4

  EDIT Maybe this could be useful here?

[bartekpacia]

Another approach idea: instead of mapping input coordinates (e.g in tapOn), let's map output coordinates when querying the view hierarchy.

This will probably work better with Maestro Studio.

[amanjeetsingh150]

nit: indentation

[bartekpacia]

I'm honeslty not sure what's the right indentation here, I haven't been writing much Swift recently.

I created #1827 to make this situation better in the future:)

[amanjeetsingh150]

What do you think about following?

1. How would a maestro user test this? Does this unblock all the recent requests that were inbound for landscape mode testing?
2. Is android working on landscape? We don't need any change there?
3. What do you think about this configuration to cloud?
4. The scenario we discussed about mid way changing the orientation? For this lets' keep that scope out of this pr we can first roll this out and see how users react and then plan to pick that. WDYT?

[bartekpacia]

How would a maestro user test this? Does this unblock all the recent requests that were inbound for landscape mode testing?

I believe it unblocks ~80% of the users who complained about landscape mode.

Is android working on landscape? We don't need any change there?

That's right, Android landscape has always worked.

What do you think about this configuration to cloud?

I consider this a quick-fix to unblock some people, who run tests locally. AFAIK Maestro Cloud doesn't allow for handling orientation changes. Maestro doesn't have a command for that as well (see #1221).

The scenario we discussed about mid way changing the orientation? For this lets' keep that scope out of this pr we can first roll this out and see how users react and then plan to pick that. WDYT?

I agree, yes!

Sum up

After this PR gets merged, there will be still 3 problems:

• (Android & iOS) Both Maestro & Maestro Studio break if device is rotate mid-flow
  • possible fix: Don't cache deviceSize
• (iOS) breaks when simulator is "physically" in landscape, but app is locked to portrait. I consider this a rare edge case and suggest we are fine with it.
  • possible fix: find iOS/XCUITest APIs that allow us to detect this situation and handle accordingly
• (iOS) Maestro Studio is broken when device is in horizontal mode
  • possible fix: explained here

But I believe this PR gets us the most value for now.

[bartekpacia]

Last night I was trying out this approach, but it failed.

Yet another idea:

maestro/maestro-ios-xctest-runner/maestro-driver-iosUITests/Routes/Handlers/TouchRouteHandler.swift

Line 26 in 1f7bbaa

let eventRecord = EventRecord(orientation: .portrait)

Maybe it's enough to just pass the current orientation there?

[amanjeetsingh150]

Maybe it's enough to just pass the current orientation there?

Sure you can check if it works. Btw heads up this is a private API so you have to check if its even available as an option.

[amanjeetsingh150]

I'm not sure if we discussed this. This could also be something we do in separate PR:

Right now maestro start-device doesn't,t support start device by default in landscape. I'm not even sure if that's possible. But it would be good if user also has an option to pass orientation while starting device.

What do you think?

[bartekpacia]

Maybe it's enough to just pass the current orientation there?

Sure you can check if it works. Btw heads up this is a private API so you have to check if its even available as an option.

I did, but it doesn't work (admittedly though I didn't try very hard). Here's the result of that small investigation (and here is what didn't work)

Right now maestro start-device doesn't support start device by default in landscape. I'm not even sure if that's possible. But it would be good if user also has an option to pass orientation while starting device.

That's right, maestro start-device doesn't have this functionality right now. Changing virtual device rotation is very easy (⌘ + ←/→), but I understand it may be very useful for users using maestro directly on CI (directly=not on managed CI like Maestro Cloud).

I made a separate issue for this: #1833

[chiefchief]

doesn't work on iPad

[bartekpacia]

@chiefchief Can you tell more? Did you build Maestro yourself locally?

This is not yet released.

[chiefchief]

@chiefchief Can you tell more? Did you build Maestro yourself locally?

This is not yet released.

as i understand, after the merge of this PR, new version was released, then i ran the command

curl -Ls "https://get.maestro.mobile.dev" | bash

which install maestro from the latest release
and the issue still exist on iPad

[bartekpacia]

So this is expected. New version (1.37.7) was released before this PR was merged.

[chiefchief]

So this is expected. New version (1.37.7) was released before this PR was merged.

Got it, thank you, i'll check once new version will be released