Another take at landscape mode #1832
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: I have no idea why, but sometimes XCUIDevice.shared.orientation changes what it returns, even when no actual orientation change happened. I mainly noticed this happening at the beginning of the flow, where first few calls to it return portrait, and the rest returns horizontal. This break everything.
|
Make sure to run ./maestro-ios-xctest-runner/build-maestro-ios-runner.sh with every swift change |
Merged
|
Note for the future: What went wrong hereThe orientation returned was changing, even though the simulator was still. For example, at the beginning of the flow, the first few calls to it That was breaking everything. It sounds weird, but that's what I saw. Possible action itemCreate a minimal repro app and call IMHO it's unlikely that it was a problem/bug in Maestro. I think it's a problem in XCUIDevice.shared.orientation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.