[Feature Request] Device rotation

[mdethlefs]

We would like to have a way to change the device rotation for our flows

[axelniklasson]

Somewhat related to #565

[dinisnunes1]

This would be key for us, since most of our app is running on landscape mode.

[bartekpacia]

Hey! could you please clarify this feature request?

• Do you want a Maestro command rotate that would rotate the device? Caveat: it would not work on physical devices. I know it's easy to do on Android emulator, using emulator console:

  rotating AVD from shell

  $ telnet localhost 5554
  Trying ::1...
  Connected to localhost.
  Escape character is '^]'.
  Android Console: Authentication required
  Android Console: type 'auth <auth_token>' to authenticate
  Android Console: you can find your <auth_token> in
  '/Users/bartek/.emulator_console_auth_token'
  OK
  auth uHnk/fBaIEhkA6jx
  Android Console: type 'help' for a list of commands
  OK
  rotate 90
  OK
  rotate -90
  OK
  rotate -90
  OK
  rotate 90
  OK
  

  Docs: https://developer.android.com/studio/run/emulator-console

• Or maybe you want Maestro Cloud to support this feature? E.g:

  $ maestro cloud \
    --android-api-level 33 \
    --orientation landscape-left `# new hypothetical option` \
    build/app/outputs/apk/debug/app-debug.apk \
    .maestro
  

[mdethlefs]

Hey @bartekpacia
We want to change orientation inside a flow. We don't want to start a flow with a certain orientation.

For example our app has a videoplayer and when you rotate your phone to landscape the fullscreen automatically activates and the player has some additional UI. When changing the orientation back the fullscreen player closes.

So we basically need something like:
- rotateHorizontal
and
- rotateVertical

[bartekpacia]

Thank you for a very quick response. I see your use case now.

I did some more googling and maybe we can also change rotation of physical Android devices with adb. StackOverflow link

As for iOS, it seems much more restricted in this area. Couldn't find anything.

Would you OK with this feature being Android only?

[mdethlefs]

I mean it would be awesome if you could do it with iOS too. But we are happy for anything in this direction - so only Android would be cool already

[TheAlmightyBob]

FWIW, in XCUITest it's possible to set the orientation with something like XCUIDevice.shared.orientation = .landscapeLeft. But I've only used that for setting initial orientation, not changing it mid-test, and I don't know how complex that would be to integrate that with Maestro.

(I would be happy with even being able to set initial orientation)

Of course, none of that really matters unless #565 is fixed...

[bartekpacia]

hey @TheAlmightyBob, thanks for the pointer. I tried it out and it indeed works:

recording.mp4

(link to the example app and test)

As for #565 - fix is on the way

[johntmcintosh]

I'm in need of this as well, and started a draft: main...johntmcintosh:maestro:feature/set-orientation. I'll see if I can get this into a PR ready state next week, but posting the diff here in case anyone has initial feedback on the direction.