This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Fix timetype #38
Open
Fix timetype #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Options to always attempt `fmt.Stringer` and to always assume `hash:"set"`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces an option,
UseBinary, which will use theencoding.MarshalBinaryinterface of any type implementing it. This fixes hashes of time value for one thing, and expands on the time.Time specific changes from #21 .Since this could be a breaking change, it is hidden behind a new "UseBinary" option. For types that implement both
fmt.Stringerandencoding.MarshalBinary(liketime.Time), and when both UseBinary and UseStringer are set, the Binary option is preferred, unless thestringtag is specifically set on the struct member.