Options to always attempt fmt.Stringer and to always assume hash:"set"
#1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For large structs and legacy code, it's nice to be able to create a checksum without first having to go through all the code and set tags on many fields.
This change introduces options to always assume that a slice is a set, and to always use the fmt.Stringer interface for a struct, if it is present.
The SlicesAsSets option overrides the tag (since it will no longer have any effect).
The UseStringer option is overridden by the tag, in the sense that if the tag is set, it is an error if the type does not implement fmt.Stringer. Using the option alone, we fall back to the default hashing, with the caveat that this means that structs with unexported fields will not be hashed if they don't implement fmt.Stringer.