This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Fix time.Time hashes #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @mitchellh |
|
@F21 Can I fork this and work on a fix since this PR is inactive EDIT: ah you're waiting for @mitchellh to review this sorry i thought someone is waiting on the fix to be worked on |
|
@mibr020 I am just waiting for a review or a merge at the moment. Hopefully someone can get aroud to it soon. |
|
This looks good. Thanks! Sorry this took literal years. Haha. |
|
Pretty sure this breaks hashing for |
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16.
time.Timeis a struct without any exported values. The current implementation treats it as a struct. Since it does not have any exported values, it's hashed as a struct with the nameTimeand nothing else. This means that anytime.Timethat is hashed will produce the same result, regardless of what its internal values are.I added a check to check if the type being hashed is a
time.Time, then use it to hash the binary version of the time (produced using theMarshalBinary()method). TheMarshalBinary()method was used because it drops the monotonic clock component of the time before returning the binary representation, otherwise, 2 identical times with different monotonic clock components will generate different hashes.