Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): Remove undefined styles #14858

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

woxtu
Copy link
Contributor

@woxtu woxtu commented Oct 28, 2024

What

コンポーネント内の未定義なスタイルを削除します。

Why

ビルドするときに出る次の警告を解決したい:

Undefined style detected: $style.root (in MkAd)
Undefined style detected: $style.captcha (in XPassword)
Undefined style detected: $style.captcha (in XPassword)
Undefined style detected: $style.captcha (in XPassword)
Undefined style detected: $style.captcha (in XPassword)
Undefined style detected: $style.captcha (in XPassword)
Undefined style detected: $style.accountSelectorRoot (in MkAuthConfirm)
Undefined style detected: $style.accountSelectorRoot (in MkAuthConfirm)
Undefined style detected: $style.root (in XAbuseReport)

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Oct 28, 2024
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 11.11111% with 8 lines in your changes missing coverage. Please review.

Project coverage is 19.39%. Comparing base (b107371) to head (62bac82).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...ages/frontend/src/components/MkSignin.password.vue 0.00% 5 Missing ⚠️
packages/frontend/src/components/MkAuthConfirm.vue 0.00% 2 Missing ⚠️
packages/frontend/src/components/MkAbuseReport.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #14858       +/-   ##
============================================
- Coverage    39.51%   19.39%   -20.13%     
============================================
  Files         1557      724      -833     
  Lines       196659   103242    -93417     
  Branches      3609      992     -2617     
============================================
- Hits         77709    20022    -57687     
+ Misses      118346    82669    -35677     
+ Partials       604      551       -53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo merged commit eecfac1 into misskey-dev:develop Oct 28, 2024
22 checks passed
@syuilo
Copy link
Member

syuilo commented Oct 28, 2024

🙏🏻

@woxtu woxtu deleted the undefined-style branch October 28, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants