feat: 絵文字のポップアップメニューに編集を追加 #15004
Merged
feat: 絵文字のポップアップメニューに編集を追加 #15004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lintのエラーが出てるので対応お願いしますー |
|
修正しました🙏 |
syuilo
reviewed
Nov 20, 2024
| os.popupMenu(menuItems, ev.currentTarget ?? ev.target); | ||
| } | ||
| } | ||
|
|
||
| const edit = async (name: string) => { | ||
| const emoji = await misskeyApiGet('emoji', { |
There was a problem hiding this comment.
編集することを考えるとキャッシュされていない方が良いからgetだとアレですね
There was a problem hiding this comment.
だとしたら既存の編集画面の実装もあわせて修正した方が良さそうですね？
syuilo
reviewed
Nov 20, 2024
| os.popupMenu(menuItems, ev.currentTarget ?? ev.target); | ||
| } | ||
| } | ||
|
|
||
| const edit = async (name: string) => { |
|
👍🏻 |
5 tasks
HotoRas
pushed a commit
to HotoRas/misskey-neko
that referenced
this pull request
Nov 24, 2024
* Mod: 絵文字のポップアップメニューに編集を追加 * fix: code styleの修正 * fix: code styleの修正 * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
絵文字のポップアップメニューに編集を追加しました。
Why
ノート(DM含む)を起点にカテゴリやタグの変更をしたい
#14264
Additional info (optional)
Checklist