Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(misskey-js): WebSocketの型定義をReconnectingWebsocketに依存するように #14850

Merged
merged 5 commits into from
Oct 28, 2024

Conversation

kakkokari-gtyih
Copy link
Contributor

What

Why

Fix #14847

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.19%. Comparing base (db95b6b) to head (e5dc4e2).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14850      +/-   ##
===========================================
+ Coverage    38.37%   41.19%   +2.81%     
===========================================
  Files         1557     1561       +4     
  Lines       196633   202418    +5785     
  Branches      3308     3642     +334     
===========================================
+ Hits         75460    83377    +7917     
+ Misses      120563   118470    -2093     
+ Partials       610      571      -39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added packages/backend Server side specific issue/PR packages/backend:test labels Oct 28, 2024
Copy link
Contributor

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

@syuilo syuilo merged commit ec4358d into misskey-dev:develop Oct 28, 2024
33 of 34 checks passed
@syuilo
Copy link
Member

syuilo commented Oct 28, 2024

🙏

@kakkokari-gtyih kakkokari-gtyih deleted the fix-14847 branch October 28, 2024 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[misskey-js] StreamをNodejs環境で扱うことが困難になっている
2 participants