Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/octopoes/filter random endpoint #704

Merged
merged 14 commits into from
Apr 25, 2023
Merged

Feature/octopoes/filter random endpoint #704

merged 14 commits into from
Apr 25, 2023

Conversation

jpbruinsslot
Copy link
Contributor

No description provided.

Lisser and others added 3 commits March 31, 2023 12:02
@Lisser
feat(octopoes): add scan-level filter for random OOI endpoint
24fc8aa
@jpbruinsslot
Merge branch 'main' into feature/octopoes/filter-random-endpoint
672236b 
* main: (41 commits)
  Bump pre-commit from 3.2.1 to 3.2.2 (#693)
  Add new xtdb-http-multinode version to 1.7 release notes (#692)
  Fix pdflatex crash when there are underscores (#690)
  fix crisis room when no description (#686)
  Appropriate min_scan_level for bits (#684)
  Handle errors from Octopoes connector (#647)
  Translate Dutch images in docs to English (#128)
  Don't set KAT_VERSION by default in .env-dist (#629)
  Feature/no bits without clearence (#645)
  Add missing migration and unit test for missing migrations (#677)
  Use `unless-stopped` Docker restart policy (#683)
  Update to xtdb-http-multinode v1.0.4 (#681)
  Remove unused SCHEDULER_DSP_INTERVAL and SCHEDULER_DSP_BROKER_URL env vars (#633)
  the latest version of nuclei updated the json-lines param (#664)
  Add MutedFinding OOI and filter them in report (#670)
  Fix djLint T001, T002, T003, T032 (#672)
  Keiko output context data (#671)
  Log pdflatex output on error (#667)
  Add djLint for Rocky templates (#626)
  Fix Keiko report downloads on uWSGI (#657)
  ...
@jpbruinsslot
Add octopoes_api scan_level support random endpoint in scheduler
e37b938
@jpbruinsslot jpbruinsslot added mula Issues related to the scheduler octopoes Issues related to octopoes labels Apr 11, 2023
@jpbruinsslot jpbruinsslot linked an issue Apr 11, 2023 that may be closed by this pull request
Optimize calls to random endpoint of octopoes api #586
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Apr 11, 2023 •
edited
Loading

File Coverage
All files 65% ❌
bits/definitions.py 64% ❌
bits/runner.py 56% ❌
bits/https_availability/https_availability.py 93% ✅
bits/oois_in_headers/oois_in_headers.py 57% ❌
bits/spf_discovery/internetnl_spf_parser.py 55% ❌
bits/spf_discovery/spf_discovery.py 72% ❌
octopoes/api/api.py 89% ✅
octopoes/api/models.py 75% ✅
octopoes/api/router.py 52% ❌
octopoes/core/app.py 69% ❌
octopoes/core/service.py 46% ❌
octopoes/events/events.py 96% ✅
octopoes/events/manager.py 65% ❌
octopoes/models/__init__.py 86% ✅
octopoes/models/datetime.py 66% ❌
octopoes/models/exception.py 83% ✅
octopoes/models/origin.py 70% ❌
octopoes/models/path.py 99% ✅
octopoes/models/types.py 95% ✅
octopoes/models/ooi/certificate.py 96% ✅
octopoes/models/ooi/email_security.py 95% ✅
octopoes/models/ooi/findings.py 94% ✅
octopoes/models/ooi/network.py 97% ✅
octopoes/models/ooi/service.py 91% ✅
octopoes/models/ooi/software.py 71% ❌
octopoes/models/ooi/web.py 81% ✅
octopoes/models/ooi/dns/records.py 95% ✅
octopoes/models/ooi/dns/zone.py 77% ✅
octopoes/repositories/ooi_repository.py 40% ❌
octopoes/repositories/origin_parameter_repository.py 53% ❌
octopoes/repositories/origin_repository.py 53% ❌
octopoes/repositories/scan_profile_repository.py 45% ❌
octopoes/xtdb/client.py 39% ❌
octopoes/xtdb/query_builder.py 69% ❌
octopoes/xtdb/related_field_generator.py 73% ❌
tests/conftest.py 91% ✅

Minimum allowed coverage is 75%

Generated by 🐒 cobertura-action against 9c1b2da

@jpbruinsslot jpbruinsslot marked this pull request as ready for review April 11, 2023 13:49
@jpbruinsslot jpbruinsslot requested a review from a team as a code owner April 11, 2023 13:49
ammar92
ammar92 reviewed Apr 18, 2023
View reviewed changes
Copy link
Contributor

@ammar92 ammar92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One remark, looks good otherwise

mula/scheduler/connectors/services/octopoes.py Outdated Show resolved Hide resolved
@Darwinkel
Copy link
Contributor

Checklist for QA:

  • I have checked out this branch, and successfully ran a fresh make kat.
  • I confirmed that there are no unintended functional regressions in this branch:
    • I have managed to pass the onboarding flow
    • Objects and Findings are created properly
    • Tasks are created and completed properly
  • I confirmed that the PR's advertised feature or hotfix works as intended.

What works:

  • Good performance and no regressions with a large set of objects and findings.

@underdarknl underdarknl merged commit 478a77c into main Apr 25, 2023
@underdarknl underdarknl deleted the feature/octopoes/filter-random-endpoint branch April 25, 2023 07:33
@dekkers dekkers mentioned this pull request Aug 22, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Donnype Donnype Donnype left review comments

@Lisser Lisser Lisser left review comments

@Darwinkel Darwinkel Darwinkel approved these changes

@ammar92 ammar92 ammar92 approved these changes

@underdarknl underdarknl underdarknl approved these changes

Assignees

@jpbruinsslot jpbruinsslot

@Lisser Lisser

Labels
mula Issues related to the scheduler octopoes Issues related to octopoes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimize calls to random endpoint of octopoes api
6 participants
@jpbruinsslot @Darwinkel @underdarknl @ammar92 @Lisser @Donnype