Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize calls to random endpoint of octopoes api #586

Closed
jpbruinsslot opened this issue Mar 28, 2023 · 2 comments · Fixed by #704
Closed

Optimize calls to random endpoint of octopoes api #586

jpbruinsslot opened this issue Mar 28, 2023 · 2 comments · Fixed by #704
Assignees
Labels
enhancement New feature or request mula Issues related to the scheduler octopoes Issues related to octopoes
Milestone

Comments

@jpbruinsslot
Copy link
Contributor

Would it be possible to have the random endpoint of octopoes api return only ooi's of specific scan levels? The scheduler calls the random endpoint and considers all the returned ooi's this could also potentially be ooi's with a scan level of 0. In order to optimize the scheduler random population it can be helpful to limit the ooi's to a certain scan level.

@jpbruinsslot jpbruinsslot added enhancement New feature or request mula Issues related to the scheduler octopoes Issues related to octopoes labels Mar 28, 2023
@jpbruinsslot jpbruinsslot added this to KAT Mar 30, 2023
@github-project-automation github-project-automation bot moved this to Incoming features / Need assessment in KAT Mar 30, 2023
@jpbruinsslot jpbruinsslot added this to the OpenKAT v1.9 milestone Mar 30, 2023
@jpbruinsslot jpbruinsslot moved this from Incoming features / Need assessment to Todo (In this sprint) in KAT Mar 30, 2023
@Lisser
Copy link
Contributor

Lisser commented Mar 31, 2023

Added functionality in the feature/octopoes/filter-random-endpoint branch:

https://github.com/minvws/nl-kat-coordination/tree/feature/octopoes/filter-random-endpoint

Still need to write test, but if you could verify that it works for you, that'd be nice

@jpbruinsslot jpbruinsslot moved this from Todo (In this sprint) to In Progress in KAT Apr 11, 2023
@jpbruinsslot jpbruinsslot linked a pull request Apr 11, 2023 that will close this issue
@jpbruinsslot jpbruinsslot moved this from In Progress to Review in KAT Apr 11, 2023
@jpbruinsslot jpbruinsslot removed their assignment Apr 24, 2023
@Lisser
Copy link
Contributor

Lisser commented Apr 24, 2023

Tests done

@Lisser Lisser moved this from Review to QA review / functional testing in KAT Apr 24, 2023
@github-project-automation github-project-automation bot moved this from QA review / functional testing to Done in KAT Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request mula Issues related to the scheduler octopoes Issues related to octopoes
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants