-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle errors from Octopoes connector #647
Merged
underdarknl
merged 2 commits into
main
from
fix/handle-findings-octopoes-connector-error
Apr 7, 2023
Merged
Handle errors from Octopoes connector #647
underdarknl
merged 2 commits into
main
from
fix/handle-findings-octopoes-connector-error
Apr 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minimum allowed coverage is Generated by 🐒 cobertura-action against 81ce6df |
ammar92
previously approved these changes
Apr 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice stuff 👍 One small remark, but consider it approved
praseodym
force-pushed
the
fix/handle-findings-octopoes-connector-error
branch
from
April 4, 2023 14:47
edfaf77
to
a6c6191
Compare
Handle errors from the Octopoes connector on the crisis room and findings pages by displaying a message to the user and logging the error to the Django logger.
praseodym
force-pushed
the
fix/handle-findings-octopoes-connector-error
branch
from
April 6, 2023 13:12
f531a34
to
044c877
Compare
underdarknl
approved these changes
Apr 7, 2023
jpbruinsslot
added a commit
that referenced
this pull request
Apr 11, 2023
* main: Add new xtdb-http-multinode version to 1.7 release notes (#692) Fix pdflatex crash when there are underscores (#690) fix crisis room when no description (#686) Appropriate min_scan_level for bits (#684) Handle errors from Octopoes connector (#647) Translate Dutch images in docs to English (#128) Don't set KAT_VERSION by default in .env-dist (#629) Feature/no bits without clearence (#645) Add missing migration and unit test for missing migrations (#677) Use `unless-stopped` Docker restart policy (#683) Update to xtdb-http-multinode v1.0.4 (#681) Remove unused SCHEDULER_DSP_INTERVAL and SCHEDULER_DSP_BROKER_URL env vars (#633) the latest version of nuclei updated the json-lines param (#664) Add MutedFinding OOI and filter them in report (#670) Fix djLint T001, T002, T003, T032 (#672) Keiko output context data (#671)
jpbruinsslot
added a commit
that referenced
this pull request
Apr 11, 2023
* main: (41 commits) Bump pre-commit from 3.2.1 to 3.2.2 (#693) Add new xtdb-http-multinode version to 1.7 release notes (#692) Fix pdflatex crash when there are underscores (#690) fix crisis room when no description (#686) Appropriate min_scan_level for bits (#684) Handle errors from Octopoes connector (#647) Translate Dutch images in docs to English (#128) Don't set KAT_VERSION by default in .env-dist (#629) Feature/no bits without clearence (#645) Add missing migration and unit test for missing migrations (#677) Use `unless-stopped` Docker restart policy (#683) Update to xtdb-http-multinode v1.0.4 (#681) Remove unused SCHEDULER_DSP_INTERVAL and SCHEDULER_DSP_BROKER_URL env vars (#633) the latest version of nuclei updated the json-lines param (#664) Add MutedFinding OOI and filter them in report (#670) Fix djLint T001, T002, T003, T032 (#672) Keiko output context data (#671) Log pdflatex output on error (#667) Add djLint for Rocky templates (#626) Fix Keiko report downloads on uWSGI (#657) ...
jpbruinsslot
added a commit
that referenced
this pull request
Apr 11, 2023
* main: (54 commits) Final djLint fixes (#701) Bump pre-commit from 3.2.1 to 3.2.2 (#693) Add new xtdb-http-multinode version to 1.7 release notes (#692) Fix pdflatex crash when there are underscores (#690) fix crisis room when no description (#686) Appropriate min_scan_level for bits (#684) Handle errors from Octopoes connector (#647) Translate Dutch images in docs to English (#128) Don't set KAT_VERSION by default in .env-dist (#629) Feature/no bits without clearence (#645) Add missing migration and unit test for missing migrations (#677) Use `unless-stopped` Docker restart policy (#683) Update to xtdb-http-multinode v1.0.4 (#681) Remove unused SCHEDULER_DSP_INTERVAL and SCHEDULER_DSP_BROKER_URL env vars (#633) the latest version of nuclei updated the json-lines param (#664) Add MutedFinding OOI and filter them in report (#670) Fix djLint T001, T002, T003, T032 (#672) Keiko output context data (#671) Log pdflatex output on error (#667) Add djLint for Rocky templates (#626) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Handle errors from the Octopoes connector on the crisis room and
findings pages by displaying a message to the user and logging the error
to the Django logger.
Issue ticket number and link
Closes #613
Proof
Extra instructions for others
This section may be skipped or omitted. Uncomment and answer the below questions if relevant.
Checklist for author(s):
feature
orhotfix
branch, in line with our git branching strategy;.env
files if I added, removed, or changed any config options, and I have informed others that they need to modify their.env
files if required;If a non-trivial PR: