Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recalculate bit when a config object changes #3206

Merged
merged 9 commits into from
Jul 10, 2024
Merged

Recalculate bit when a config object changes #3206

merged 9 commits into from
Jul 10, 2024

Conversation

originalsouth
Copy link
Contributor

@originalsouth originalsouth commented Jul 9, 2024 •
edited
Loading

Changes

Recalculate bit when a config object changes, to address "Question OOIs are not properly handled in backend" as described #3192.

Issue link

Closes #3192.

Demo

image

image

QA notes

Please add some information for QA on how to test the newly created code.

Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue.
  • I have written unit tests for the changes or fixes I made.
  • I have checked the documentation and made changes where necessary.
  • I have performed a self-review of my code and refactored it to the best of my abilities.
  • Tickets have been created for newly discovered issues.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.

Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@originalsouth originalsouth requested a review from a team as a code owner July 9, 2024 11:12
@originalsouth originalsouth self-assigned this Jul 9, 2024
@originalsouth originalsouth added bug Something isn't working octopoes Issues related to octopoes backend bits labels Jul 9, 2024
@originalsouth originalsouth changed the title Recalculate bit if a config object changes Recalculate bit when a config object changes Jul 9, 2024
ammar92
ammar92 reviewed Jul 9, 2024
View reviewed changes
octopoes/octopoes/core/service.py Outdated Show resolved Hide resolved
octopoes/octopoes/core/service.py Outdated Show resolved Hide resolved
ammar92
ammar92 approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@ammar92 ammar92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! No further remarks

@originalsouth
Copy link
Contributor Author

Merge main: angry Sigrid
¯\_(ツ)_/¯

@stephanie0x00 stephanie0x00 mentioned this pull request Jul 10, 2024
Merged
9 tasks
@stephanie0x00
Copy link
Contributor

Checklist for QA:

  • I have checked out this branch, and successfully ran a fresh make reset.
  • I confirmed that there are no unintended functional regressions in this branch:
    • I have managed to pass the onboarding flow
    • Objects and Findings are created properly
    • Tasks are created and completed properly
  • I confirmed that the PR's advertised feature or hotfix works as intended.
  • I checked the logs for errors and/or warnings and made issues where necessary

What works:

Very nice work! Answering the Question results in the Config and thus the corresponding CSP finding. Updating the Question removes the finding automatically. I also tested if re-adding the bad hostname would would and it did.

What doesn't work:

n/a

Bug or feature?:

n/a

@underdarknl underdarknl merged commit 1b518cf into main Jul 10, 2024
18 of 19 checks passed
@underdarknl underdarknl deleted the feature/3192-rerun-relevant-bits-on-update-config-ooi branch July 10, 2024 12:43
jpbruinsslot added a commit that referenced this pull request Jul 16, 2024
@jpbruinsslot
Merge branch 'main' into feature/mula/refactor-queue
78e0101 
* main: (31 commits)
  Refactor Task List and filters with error handlers for Scheduler  (#1957)
  Fix filtering on plugin_id for normalizers (#3226)
  Implement `structlog` (#3175)
  Gather BIT metrics [implementation] (#3122)
  Add observation data to observation table in OOI detail page (#3186)
  cve-2024-6387 from RickGeex (#3194)
  Recalculate bit when a config object changes (#3206)
  Use more concise regexes (#3181)
  Updated Django (#3217)
  Updated `zipp` (#3215)
  Feature/boefje normalizer config models (#3118)
  Updated `certifi` (#3209)
  Add pluginToggler.js to Aggregate Report (#3202)
  Update to Django 5.0 (#2939)
  Update Dockerfile, fix Sonarcloud issue (#3180)
  Better default list of world writable domains in CSP checker (#3165)
  Update 1.16 release notes (#3195)
  Remove non standard header findings and add deprecated headers findings (#3127)
  Fix/sonarcloud https redirect dockerfiles (#3185)
  Bump docker/build-push-action from 5 to 6 (#3164)
  ...
@originalsouth originalsouth restored the feature/3192-rerun-relevant-bits-on-update-config-ooi branch July 29, 2024 14:07
@originalsouth originalsouth deleted the feature/3192-rerun-relevant-bits-on-update-config-ooi branch July 29, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ammar92 ammar92 ammar92 approved these changes

@underdarknl underdarknl underdarknl approved these changes

Assignees

@originalsouth originalsouth

Labels
backend bits bug Something isn't working octopoes Issues related to octopoes
Projects
KAT
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Question OOIs are not properly handled in backend
4 participants
@originalsouth @stephanie0x00 @underdarknl @ammar92