-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/boefje normalizer config models #3118
Conversation
Fix the integration tests Remove repository references in Rocky
Test upgrading and downgrading with uniqueness issue Set empty not-nullable foreign key to repository to seeded "LOCAL" on downgrades
… in other modules. Signed-off-by: Donny Peeters <[email protected]>
Signed-off-by: Donny Peeters <[email protected]>
Signed-off-by: Donny Peeters <[email protected]>
Signed-off-by: Donny Peeters <[email protected]>
…ment where we do read-only operations.
Improve update logic for local plugins, allowing overriding only specified fields
Set type to str again since the values were not compatible
Signed-off-by: Donny Peeters <[email protected]>
Fix other references to the app module that has been removed Update the other relevant documentation on seeding the KATalogus database, which is no longer needed Signed-off-by: Donny Peeters <[email protected]>
…ormalizer-config-models
…ormalizer-config-models # Conflicts: # boefjes/boefjes/dependencies/plugins.py # boefjes/boefjes/katalogus/plugins.py # boefjes/boefjes/katalogus/root.py # boefjes/boefjes/storage/interfaces.py # boefjes/tests/integration/test_api.py # boefjes/tests/katalogus/test_plugins_api.py
Allow creation of static local plugins in the database as well, but only for the config models. Do not allow updates on static plugin models in the database
…ormalizer-config-models
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me in general, but I didn't dive into it too deeply because of its vastness.
Overal refactoring (and move of the katalogus
module tests) seemed necessary and the tests look good.
Checklist for QA:
What works:Looks good. Enabled all boefjes that do not require API keys and/or additional settings and they all run like a charm. Some normalizers throw errors, but those are different issues. Reports can be generated, all the links on the Katalogus details page are present and work. What doesn't work:n/a Bug or feature?:n/a |
* main: (31 commits) Refactor Task List and filters with error handlers for Scheduler (#1957) Fix filtering on plugin_id for normalizers (#3226) Implement `structlog` (#3175) Gather BIT metrics [implementation] (#3122) Add observation data to observation table in OOI detail page (#3186) cve-2024-6387 from RickGeex (#3194) Recalculate bit when a config object changes (#3206) Use more concise regexes (#3181) Updated Django (#3217) Updated `zipp` (#3215) Feature/boefje normalizer config models (#3118) Updated `certifi` (#3209) Add pluginToggler.js to Aggregate Report (#3202) Update to Django 5.0 (#2939) Update Dockerfile, fix Sonarcloud issue (#3180) Better default list of world writable domains in CSP checker (#3165) Update 1.16 release notes (#3195) Remove non standard header findings and add deprecated headers findings (#3127) Fix/sonarcloud https redirect dockerfiles (#3185) Bump docker/build-push-action from 5 to 6 (#3164) ...
Disclaimer
Forgive me father, for I have sinned: I did refactoring in my feature branch. Although I think refactoring is often a crucial part of a feature, in this case these were a bit unrelated. Nevertheless, note that I moved the test-directory from the katalogus dir to the central boefjes directory for consistency with the other services (and the fact that we don't have that many test files), and the same holds for the dependencies directory which contains dependencies not strictly related to the KATalogus API. Some are used by the boefjes workers as well. Just don't let the amount of files changed distract you: most were just moved.
Changes
This feature adds the config models in this overview (as part of this epic):
These changes should be backward compatible, as has been tested with migration tests. The API is left intact as well.
Issue link
Closes #3014
QA notes
Please verify that the KATalogus works properly, in terms of enabling/disabling and changing/updating/copying settings. Also please check that upgrading to this branch does not disable previously disabled plugins or delete your settings. That shouldn't happen.
Code Checklist
.env
changes files if required and changed the.env-dist
accordingly.Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.