Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better default list of world writable domains in CSP checker #3165

Merged
merged 8 commits into from
Jul 8, 2024
Merged

Better default list of world writable domains in CSP checker #3165

merged 8 commits into from
Jul 8, 2024

Conversation

underdarknl
Copy link
Contributor

@underdarknl underdarknl commented Jul 1, 2024 •
edited
Loading

Changes

The current 'default' list of domains was not very helpfull, This PR adds in the few domains listed in the original issue.

Issue link

#2571

QA notes

The CSP config bit should show these new defaults.

Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue.
  • I have written unit tests for the changes or fixes I made.
  • I have checked the documentation and made changes where necessary.
  • I have performed a self-review of my code and refactored it to the best of my abilities.
  • Tickets have been created for newly discovered issues.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.

Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@underdarknl underdarknl requested a review from a team as a code owner July 1, 2024 11:56
noamblitz
noamblitz previously approved these changes Jul 1, 2024
View reviewed changes
ammar92
ammar92 previously approved these changes Jul 2, 2024
View reviewed changes
@underdarknl underdarknl dismissed stale reviews from noamblitz and ammar92 via 33e88d5 July 2, 2024 12:36
@noamblitz noamblitz self-assigned this Jul 4, 2024
@stephanie0x00 stephanie0x00 mentioned this pull request Jul 4, 2024
Closed
@stephanie0x00
Copy link
Contributor

QA is currently not possible since Question oois (which are required for testing) are not properly handled by the backend. Ticket #3192 is created for this. We can merge this and when #3192 is fixed we can test this properly.

@dekkers dekkers changed the title better list of world writable domains csp checker Better default list of world writable domains in CSP checker Jul 8, 2024
@dekkers dekkers merged commit 7c68d0a into main Jul 8, 2024
20 checks passed
@dekkers dekkers deleted the feat/csp-world-writable-domains-defaults branch July 8, 2024 08:19
jpbruinsslot added a commit that referenced this pull request Jul 16, 2024
@jpbruinsslot
Merge branch 'main' into feature/mula/refactor-queue
78e0101 
* main: (31 commits)
  Refactor Task List and filters with error handlers for Scheduler  (#1957)
  Fix filtering on plugin_id for normalizers (#3226)
  Implement `structlog` (#3175)
  Gather BIT metrics [implementation] (#3122)
  Add observation data to observation table in OOI detail page (#3186)
  cve-2024-6387 from RickGeex (#3194)
  Recalculate bit when a config object changes (#3206)
  Use more concise regexes (#3181)
  Updated Django (#3217)
  Updated `zipp` (#3215)
  Feature/boefje normalizer config models (#3118)
  Updated `certifi` (#3209)
  Add pluginToggler.js to Aggregate Report (#3202)
  Update to Django 5.0 (#2939)
  Update Dockerfile, fix Sonarcloud issue (#3180)
  Better default list of world writable domains in CSP checker (#3165)
  Update 1.16 release notes (#3195)
  Remove non standard header findings and add deprecated headers findings (#3127)
  Fix/sonarcloud https redirect dockerfiles (#3185)
  Bump docker/build-push-action from 5 to 6 (#3164)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dekkers dekkers dekkers approved these changes

@noamblitz noamblitz noamblitz left review comments

@ammar92 ammar92 ammar92 left review comments

Assignees

@noamblitz noamblitz

Labels
None yet
Projects
KAT
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@underdarknl @stephanie0x00 @dekkers @ammar92 @noamblitz