Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove containers after docker-compose run #1112

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

praseodym
Copy link
Contributor

Changes

Remove containers after docker-compose run. This prevents e.g. katalogus-run-... containers from piling up in development environments.

Issue link

n/a

Proof

n/a


Code Checklist

  • All the commits in this PR are properly PGP-signed and verified;
  • This PR only contains functionality relevant to the issue; tickets have been created for newly discovered issues.
  • I have written unit tests for the changes or fixes I made.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have performed a self-review of my code and refactored it to the best of my abilities.

Communication

  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have made corresponding changes to the documentation, if necessary.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

Prevents e.g. `katalogus-run-...` containers from piling up in
development environments.
@praseodym praseodym requested a review from a team as a code owner June 6, 2023 07:05
Copy link
Contributor

@Donnype Donnype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@dekkers dekkers merged commit 2f5ad3d into main Jun 6, 2023
@dekkers dekkers deleted the fix/remove-docker-compose-run-containers branch June 6, 2023 07:40
jpbruinsslot added a commit that referenced this pull request Jun 12, 2023
* main:
  Add bit to set default values for FindingType risk levels in Octopoes (#1075)
  Fix thread termination in Mula (#1003)
  test(boefjes): snyk (#1116)
  Add endpoints in Octopoes for bulk operations in the object list page (#1067)
  Remove tasks and items on mutation delete (#1090)
  Persist impact, recommendation and source fields in FindingType objects in XTDB (#1126)
  Handle an empty plugin.consumes field for the plugin detail page (#1104)
  Add script to automatically backport PR to release branch (#1097)
  Fix typos in 'no organizations found' message (#1123)
  Finding Types Boefjes (#1056)
  add findingtype files (#1117)
  Remove containers after `docker-compose run` (#1112)
  Bump cryptography from 39.0.1 to 41.0.0 in /boefjes/boefjes/plugins/kat_ssl_certificates (#1099)
  Bump cryptography from 40.0.2 to 41.0.1 (#1108)
  Bump cryptography from 40.0.2 to 41.0.0 in /bytes (#1100)
  Fix failing test-debian-install in CI (#1111)
  Remove unused boefje fields when creating a BoefjeTask object to send to the scheduler (#1103)
  add 'ideas' as a category in project guidelines (#1105)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants