Persist impact, recommendation and source fields in FindingType objects in XTDB #1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lisser
force-pushed
the
add-fields-to-kat-finding-types-json
branch
from
ad99f59
to
910ac8f
Compare
Lisser
force-pushed
the
add-fields-to-kat-finding-types-json
branch
from
910ac8f
to
7b9b0f5
Compare
Lisser
changed the title
Lisser
changed the title
Lisser
changed the title
|
What else needs to be done before the data that's now in |
Basically, stop accessing it in Rocky. This is being worked on in #1118 |
There are also a few descriptions of models in the seed. I think it would be best to move those descriptions to the models itself. |
dekkers
approved these changes
Jun 7, 2023
jpbruinsslot
added a commit
that referenced
this pull request
Jun 12, 2023
* main: Add bit to set default values for FindingType risk levels in Octopoes (#1075) Fix thread termination in Mula (#1003) test(boefjes): snyk (#1116) Add endpoints in Octopoes for bulk operations in the object list page (#1067) Remove tasks and items on mutation delete (#1090) Persist impact, recommendation and source fields in FindingType objects in XTDB (#1126) Handle an empty plugin.consumes field for the plugin detail page (#1104) Add script to automatically backport PR to release branch (#1097) Fix typos in 'no organizations found' message (#1123) Finding Types Boefjes (#1056) add findingtype files (#1117) Remove containers after `docker-compose run` (#1112) Bump cryptography from 39.0.1 to 41.0.0 in /boefjes/boefjes/plugins/kat_ssl_certificates (#1099) Bump cryptography from 40.0.2 to 41.0.1 (#1108) Bump cryptography from 40.0.2 to 41.0.0 in /bytes (#1100) Fix failing test-debian-install in CI (#1111) Remove unused boefje fields when creating a BoefjeTask object to send to the scheduler (#1103) add 'ideas' as a category in project guidelines (#1105)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add
impact,recommendationandsourcefields to kat_finding_types.jsonAdd
impact,recommendationandsourcefields to FindingType modelYield
impact,recommendationandsourcefrom KATFindingType normalizerYield
sourcefrom CVEFindingType normalizerYield
sourcefrom SnykFindingType normalizerIssue link
Closes N/A
Proof
Code Checklist
Communication
.envchanges files if required and changed the.env-distaccordingly.Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.