Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove containers after docker-compose run #1112

Merged
merged 1 commit into from
Jun 6, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions boefjes/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ help: ## Show this help.
build: seed

seed: # Seed the katalogus database
-docker-compose run katalogus python -m boefjes.seed
-docker-compose run --rm katalogus python -m boefjes.seed

##
##|------------------------------------------------------------------------|
Expand All @@ -42,12 +42,12 @@ migrations: ## Generate a migration using alembic
ifeq ($(m),)
$(HIDE) (echo "Specify a message with m={message} and a rev-id with revid={revid} (e.g. 0001 etc.)"; exit 1)
else
docker-compose run katalogus python -m alembic --config /app/boefjes/boefjes/alembic.ini revision --autogenerate -m "$(m)"
docker-compose run --rm katalogus python -m alembic --config /app/boefjes/boefjes/alembic.ini revision --autogenerate -m "$(m)"
endif


sql: ## Generate raw sql for the migrations
docker-compose run katalogus python -m alembic --config /app/boefjes/boefjes/alembic.ini upgrade $(rev1):$(rev2) --sql
docker-compose run --rm katalogus python -m alembic --config /app/boefjes/boefjes/alembic.ini upgrade $(rev1):$(rev2) --sql

check:
pre-commit run --all-files --color always
Expand Down
2 changes: 1 addition & 1 deletion bytes/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ done: lint test ## Prepare for a commit.
lint: ## Format the code using black.
pre-commit run --all-files --show-diff-on-failure --color always

py-run := docker-compose run bytes python
py-run := docker-compose --rm run bytes python


export revid
Expand Down
2 changes: 1 addition & 1 deletion mula/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ ifeq ($(m),)
else ifeq ($(revid),)
$(HIDE) (echo "ERROR: Specify a message with m={message} and a rev-id with revid={revid} (e.g. 0001 etc.)"; exit 1)
else
docker-compose run scheduler \
docker-compose run --rm scheduler \
alembic --config /app/scheduler/scheduler/alembic.ini \
revision --autogenerate \
-m "$(m)" --rev-id "$(revid)"
Expand Down