Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: update knowhere version #37510

Merged
merged 1 commit into from
Nov 13, 2024
Merged

enhance: update knowhere version #37510

merged 1 commit into from
Nov 13, 2024

Conversation

foxspy
Copy link
Contributor

@foxspy foxspy commented Nov 7, 2024

issue: #36925

@sre-ci-robot sre-ci-robot added size/XS Denotes a PR that changes 0-9 lines. area/compilation labels Nov 7, 2024
@foxspy foxspy changed the title enhance : update knowhere version enhance: update knowhere version Nov 7, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 7, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 7, 2024

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@foxspy
Copy link
Contributor Author

foxspy commented Nov 7, 2024

/run-cpu-e2e

@codecov Codecov
Copy link

codecov bot commented Nov 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.07%. Comparing base (b5b0035) to head (f252d2e).
Report is 14 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #37510      +/-   ##
==========================================
- Coverage   68.13%   68.07%   -0.07%     
==========================================
  Files         290      290              
  Lines       25392    25455      +63     
==========================================
+ Hits        17302    17328      +26     
- Misses       8090     8127      +37
Components Coverage Δ
Client ∅ <ø> (∅)
Core 68.07% <ø> (-0.07%) ⬇️
Go ∅ <ø> (∅)

see 7 files with indirect coverage changes

@foxspy foxspy force-pushed the update_knowhere_version branch 3 times, most recently from 57ad465 to d0836e1 Compare November 8, 2024 06:24
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 8, 2024

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@foxspy
Copy link
Contributor Author

foxspy commented Nov 8, 2024

/run-cpu-e2e

@foxspy foxspy force-pushed the update_knowhere_version branch from d0836e1 to c1ece04 Compare November 10, 2024 15:28
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 10, 2024

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@foxspy
Copy link
Contributor Author

foxspy commented Nov 11, 2024

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 11, 2024

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@foxspy
Copy link
Contributor Author

foxspy commented Nov 11, 2024

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 11, 2024

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@czs007
Copy link
Collaborator

czs007 commented Nov 11, 2024

/approve

@foxspy foxspy force-pushed the update_knowhere_version branch from c1ece04 to d2d0591 Compare November 11, 2024 16:16
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 11, 2024

@foxspy cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 11, 2024

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@foxspy foxspy force-pushed the update_knowhere_version branch 2 times, most recently from fe3f8b5 to 8c73168 Compare November 12, 2024 09:22
@sre-ci-robot sre-ci-robot added area/dependency Pull requests that update a dependency file and removed size/XS Denotes a PR that changes 0-9 lines. labels Nov 12, 2024
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Nov 12, 2024
@foxspy foxspy force-pushed the update_knowhere_version branch 4 times, most recently from 059b4d6 to 01f34fd Compare November 13, 2024 03:28
@foxspy
update knowhere version
f252d2e 
Signed-off-by: xianliang.li <[email protected]>
@foxspy foxspy force-pushed the update_knowhere_version branch from 01f34fd to f252d2e Compare November 13, 2024 04:17
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 13, 2024

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@foxspy
Copy link
Contributor Author

foxspy commented Nov 13, 2024

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Nov 13, 2024
@czs007
Copy link
Collaborator

czs007 commented Nov 13, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, foxspy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit cf883b1 into milvus-io:master Nov 13, 2024
17 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@godchen0212 godchen0212 Awaiting requested review from godchen0212

Assignees

@czs007 czs007

Labels
approved area/compilation area/dependency Pull requests that update a dependency file ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@foxspy @czs007 @sre-ci-robot