update knowhere version

Signed-off-by: xianliang.li <[email protected]>
milvus-io · Nov 11, 2024 · d2d0591 · d2d0591
1 parent 81141bd
commit d2d0591
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/internal/core/thirdparty/knowhere/CMakeLists.txt b/internal/core/thirdparty/knowhere/CMakeLists.txt
@@ -14,7 +14,7 @@
 # Update KNOWHERE_VERSION for the first occurrence
 milvus_add_pkg_config("knowhere")
 set_property(DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR} PROPERTY INCLUDE_DIRECTORIES "")
-set( KNOWHERE_VERSION e67abe7 )
+set( KNOWHERE_VERSION bfccf6a )
 set( GIT_REPOSITORY  "https://github.com/zilliztech/knowhere.git")
 message(STATUS "Knowhere repo: ${GIT_REPOSITORY}")
 message(STATUS "Knowhere version: ${KNOWHERE_VERSION}")

diff --git a/internal/util/indexparamcheck/float_vector_base_checker_test.go b/internal/util/indexparamcheck/float_vector_base_checker_test.go
@@ -63,7 +63,7 @@ func Test_floatVectorBaseChecker_CheckValidDataType(t *testing.T) {
 		},
 		{
 			dType:    schemapb.DataType_BinaryVector,
-			errIsNil: true,
+			errIsNil: false,
 		},
 	}
 

diff --git a/internal/util/indexparamcheck/hnsw_checker_test.go b/internal/util/indexparamcheck/hnsw_checker_test.go
@@ -165,7 +165,7 @@ func Test_hnswChecker_CheckValidDataType(t *testing.T) {
 		},
 		{
 			dType:    schemapb.DataType_BinaryVector,
-			errIsNil: true,
+			errIsNil: false,
 		},
 	}
 

diff --git a/internal/util/vecindexmgr/vector_index_mgr_test.go b/internal/util/vecindexmgr/vector_index_mgr_test.go
@@ -67,7 +67,7 @@ func Test_VecIndex_DataType_Support(t *testing.T) {
 				schemapb.DataType_Float16Vector,
 				schemapb.DataType_SparseFloatVector,
 			},
-			wants: []bool{true, true, true, true, false},
+			wants: []bool{true, false, true, true, false},
 		},
 		{
 			indexType: "DISKANN",
-Original file line number
+Diff line change
@@ Expand Up @@
     		},
     		{
     			dType:    schemapb.DataType_BinaryVector,
-    			errIsNil: true,
+    			errIsNil: false,
     		},
     	}
@@ Expand Down @@