Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: [new_indexes] The name for new HNSW SQ/PQ/PRQ indexes are "FAISS_HNSW_**" not "HNSW_**" #36925

Closed
1 task done
binbinlv opened this issue Oct 16, 2024 · 11 comments
Closed
1 task done
Assignees
Labels
2.5-features kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone

Comments

@binbinlv
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Environment

- Milvus version: master-20241015-f3b6792a
- Deployment mode(standalone or cluster): both
- MQ type(rocksmq, pulsar or kafka):    all 
- SDK version(e.g. pymilvus v2.0.0rc2): 2.5.0rc97
- OS(Ubuntu or CentOS): 
- CPU/Memory: 
- GPU: 
- Others:

Current Behavior

The name for new HNSW SQ/PQ/PRQ indexes are "FAISS_HNSW_" not "HNSW_":

FAISS_HNSW_FLAT
FAISS_HNSW_SQ
FAISS_HNSW_PQ
FAISS_HNSW_PRQ

Expected Behavior

HNSW_FLAT
HNSW_SQ
HNSW_PQ
HNSW_PRQ

Steps To Reproduce

NA

Milvus Log

No response

Anything else?

No response

@binbinlv binbinlv added kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Oct 16, 2024
@binbinlv binbinlv added this to the 2.5.0 milestone Oct 16, 2024
@binbinlv binbinlv changed the title [Bug]: The name for new HNSW SQ/PQ/PRQ indexes are "FAISS_HNSW_**" not "HNSW_**" [Bug]: [new_indexes] The name for new HNSW SQ/PQ/PRQ indexes are "FAISS_HNSW_**" not "HNSW_**" Oct 16, 2024
@alexanderguzhva
Copy link
Contributor

/assign @alexanderguzhva

@alexanderguzhva
Copy link
Contributor

this is temporarily while we finish all checks

@foxspy
Copy link
Contributor

foxspy commented Nov 1, 2024

@alexanderguzhva Have you tried building index and loading it with FAISS HNSW? If you change the name, you should take care it can successfully load the index built before

@alexanderguzhva
Copy link
Contributor

@foxspy that was my first question to @liliu-z and @xiaofan-luan

@foxspy
Copy link
Contributor

foxspy commented Nov 4, 2024

track: zilliztech/knowhere#921

@liliu-z
Copy link
Member

liliu-z commented Nov 4, 2024

@foxspy that was my first question to @liliu-z and @xiaofan-luan

Yes, we need to be able to load the binary built by the old HNSW. The backward compatibility need to be ensured for a middle version, so we can stop the support from 2.6 or 3.0

@liliu-z
Copy link
Member

liliu-z commented Nov 4, 2024

Also we need to support both HNSW and HNSW_FLAT as the name for this version

@foxspy
Copy link
Contributor

foxspy commented Nov 12, 2024

/assign

sre-ci-robot pushed a commit that referenced this issue Nov 13, 2024
@binbinlv
Copy link
Contributor Author

/assign

@binbinlv
Copy link
Contributor Author

working on verification

@binbinlv
Copy link
Contributor Author

Verified and fixed, all index names are changed.

milvus: master-20241114-1304b405-amd64
pymilvus: 2.5.0rc119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.5-features kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

5 participants