-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: Skip loading bf in datanode #36367
Conversation
Signed-off-by: bigsheeper <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #36367 +/- ##
==========================================
- Coverage 82.34% 73.33% -9.02%
==========================================
Files 1278 1278
Lines 150846 150841 -5
==========================================
- Hits 124220 110619 -13601
- Misses 21639 35226 +13587
- Partials 4987 4996 +9
|
/lgtm |
Signed-off-by: bigsheeper <[email protected]>
@bigsheeper E2e jenkins job failed, comment |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bigsheeper, czs007 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Remove bf from datanode: 1. When watching vchannels, skip loading **flushed** segments's bf. For generating merged bf, we need to keep loading **growing** segments's bf. 2. Bypass bloom filter checks for delete messages, directly writing to L0 segments. 3. In version 2.4, when dropping a partition, marking segments as dropped depends on having the full segment list in the DataNode. So, we need to keep syncing the segments every 10 minutes. issue: #34585 pr: #35902, #36367, #36592 --------- Signed-off-by: bigsheeper <[email protected]>
Skip loading bf in datanode:
issue: #34585