Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Skip loading bf in datanode #36367

Merged
merged 8 commits into from
Sep 26, 2024

Conversation

bigsheeper
Copy link
Contributor

Skip loading bf in datanode:

  1. When watching vchannels, skip loading bloom filters for segments.
  2. Bypass bloom filter checks for delete messages, directly writing to L0 segments.
  3. Remove flushed segments proactively after flush.

issue: #34585

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Sep 19, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Sep 19, 2024
@mergify mergify bot added the ci-passed label Sep 19, 2024
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 64.86486% with 13 lines in your changes missing coverage. Please review.

Project coverage is 73.33%. Comparing base (ddadefc) to head (e482306).
Report is 21 commits behind head on master.

Files with missing lines Patch % Lines
internal/flushcommon/pipeline/data_sync_service.go 68.00% 6 Missing and 2 partials ⚠️
internal/datanode/data_node.go 0.00% 1 Missing and 1 partial ⚠️
internal/streamingnode/server/server.go 0.00% 1 Missing and 1 partial ⚠️
internal/datacoord/server.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #36367      +/-   ##
==========================================
- Coverage   82.34%   73.33%   -9.02%     
==========================================
  Files        1278     1278              
  Lines      150846   150841       -5     
==========================================
- Hits       124220   110619   -13601     
- Misses      21639    35226   +13587     
- Partials     4987     4996       +9     
Files with missing lines Coverage Δ
...nternal/flushcommon/writebuffer/l0_write_buffer.go 47.05% <100.00%> (-46.33%) ⬇️
internal/flushcommon/writebuffer/write_buffer.go 77.34% <100.00%> (-2.12%) ⬇️
pkg/util/paramtable/component_param.go 98.30% <100.00%> (+<0.01%) ⬆️
internal/datacoord/server.go 74.25% <0.00%> (-0.32%) ⬇️
internal/datanode/data_node.go 78.01% <0.00%> (-0.83%) ⬇️
internal/streamingnode/server/server.go 87.09% <0.00%> (-6.01%) ⬇️
internal/flushcommon/pipeline/data_sync_service.go 75.49% <68.00%> (+7.58%) ⬆️

... and 243 files with indirect coverage changes

@chyezh
Copy link
Contributor

chyezh commented Sep 20, 2024

/lgtm

pkg/config/manager.go Outdated Show resolved Hide resolved
@sre-ci-robot sre-ci-robot removed the lgtm label Sep 20, 2024
@mergify mergify bot removed the ci-passed label Sep 20, 2024
Copy link
Contributor

mergify bot commented Sep 20, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@czs007
Copy link
Collaborator

czs007 commented Sep 26, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 9e8cafc into milvus-io:master Sep 26, 2024
14 of 16 checks passed
sre-ci-robot pushed a commit that referenced this pull request Oct 22, 2024
Remove bf from datanode:
1. When watching vchannels, skip loading **flushed** segments's bf. For
generating merged bf, we need to keep loading **growing** segments's bf.
2. Bypass bloom filter checks for delete messages, directly writing to
L0 segments.
3. In version 2.4, when dropping a partition, marking segments as
dropped depends on having the full segment list in the DataNode. So, we
need to keep syncing the segments every 10 minutes.

issue: #34585

pr: #35902,
#36367,
#36592

---------

Signed-off-by: bigsheeper <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants