-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement]: Add segment id hint in multi-stage operations #36482
Comments
ProposeRecord pre-calculated segment id result from PK as segment hints and utilize them in following stages Fallback mechanismWhen compaction happens, the segment hints may be out-of-date so the detection & fallback mechanism is needed. The default fallback behavior is to act like the hint never exists, which is to iterate all candidates and re-calculate the segment ids. CompatibilityThe segment hints fields are newly added so that old components will just ignore the hint and act like fallback behavior. So there shall be no compatibility issue here. |
Delete By expressionthe delete data route is relevant to multiple components: proxy, mq, datanode, querynode & storage. Complex deletionDelete by expression(aka complex delete) is separated into multiple steps:
The Action items here:
Utilizing segment hint processing deleteDatanodeThere are two feature could be related to segment hints
QueryNodeThe delegator need to forward streaming the streaming and l0 delta data into corresponding segments. Both task could utilize segment id hint as long as the delete data contains them.
|
Related to milvus-io#36482 This PR reuses `SealedSegmentIDsRetrieved` field in `RetrieveResults` struct to store segment id hint. Signed-off-by: Congqi Xia <[email protected]>
Related to milvus-io/milvus#36482 Signed-off-by: Congqi Xia <[email protected]>
Related to #36482 This PR reuses `SealedSegmentIDsRetrieved` field in `RetrieveResults` struct to store segment id hint. Signed-off-by: Congqi Xia <[email protected]>
Related to milvus-io/milvus#36482 Signed-off-by: Congqi Xia <[email protected]>
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Is there an existing issue for this?
What would you like to be added?
Add segment id hint in multi-stage operations like: "Requery", "DeleteByExpression", "L0Compaction", etc.
Why is this needed?
There are lots of duplicate execution in previous mentioned operations, especially to location segment id from input PK values. Some of them are proven to be the bottlenecks in some extreme use case.
Anything else?
No response
The text was updated successfully, but these errors were encountered: