fix: stats log lost after disable stats log loading on flush #36592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chyezh <[email protected]>
mergify
bot
added
dco-passed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #36592 +/- ##
==========================================
- Coverage 82.32% 73.40% -8.93%
==========================================
Files 1281 1281
Lines 151551 151545 -6
==========================================
- Hits 124760 111235 -13525
- Misses 21763 35292 +13529
+ Partials 5028 5018 -10
|
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chyezh, czs007 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sre-ci-robot
pushed a commit
that referenced
this pull request
Oct 22, 2024
Remove bf from datanode: 1. When watching vchannels, skip loading **flushed** segments's bf. For generating merged bf, we need to keep loading **growing** segments's bf. 2. Bypass bloom filter checks for delete messages, directly writing to L0 segments. 3. In version 2.4, when dropping a partition, marking segments as dropped depends on having the full segment list in the DataNode. So, we need to keep syncing the segments every 10 minutes. issue: #34585 pr: #35902, #36367, #36592 --------- Signed-off-by: bigsheeper <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #36555