-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fill the metric type field in the LoadMetaInfo object #35962
Conversation
SimFG
commented
Sep 4, 2024
•
edited
Loading
edited
- issue: [Bug]: Fail to search when upgrading the server from 2.3.x to 2.4.x #35960
Signed-off-by: SimFG <[email protected]>
) - issue: #35960 - pr: #35962 Signed-off-by: SimFG <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #35962 +/- ##
==========================================
- Coverage 81.57% 72.61% -8.96%
==========================================
Files 1265 1265
Lines 150790 150469 -321
==========================================
- Hits 123002 109269 -13733
- Misses 22896 36332 +13436
+ Partials 4892 4868 -24
|
…ct (#35964) - issue: #35960 - pr: #35962 Signed-off-by: SimFG <[email protected]>
we don't need to set setMetricTypeForMetaInfo for master? |
This error occurs when the querynode delegator of 2.4 sends a request to the querynode worker of 2.3. Considering that the master will be 2.5, which is upgraded from 2.4, to avoid being used by others, no setting is made in the master |
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SimFG, xiaofan-luan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…#35962) - issue: milvus-io#35960 Signed-off-by: SimFG <[email protected]>
- issue: #35960 - pr: #35962 Signed-off-by: SimFG <[email protected]>