Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fill the metric type field in the LoadMetaInfo object #35962

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

SimFG
Copy link
Contributor

@SimFG SimFG commented Sep 4, 2024

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Sep 4, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Sep 4, 2024
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.61%. Comparing base (ea36d13) to head (8d425ba).
Report is 25 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #35962      +/-   ##
==========================================
- Coverage   81.57%   72.61%   -8.96%     
==========================================
  Files        1265     1265              
  Lines      150790   150469     -321     
==========================================
- Hits       123002   109269   -13733     
- Misses      22896    36332   +13436     
+ Partials     4892     4868      -24     
Files with missing lines Coverage Δ
internal/core/src/query/SearchOnSealed.cpp 0.00% <ø> (-100.00%) ⬇️
internal/core/src/segcore/ConcurrentVector.h 89.05% <ø> (-8.03%) ⬇️
internal/datanode/compaction/segment_writer.go 80.45% <ø> (ø)

... and 252 files with indirect coverage changes

xiaofan-luan pushed a commit that referenced this pull request Sep 4, 2024
@xiaofan-luan
Copy link
Collaborator

we don't need to set setMetricTypeForMetaInfo for master?

@SimFG
Copy link
Contributor Author

SimFG commented Sep 5, 2024

This error occurs when the querynode delegator of 2.4 sends a request to the querynode worker of 2.3. Considering that the master will be 2.5, which is upgraded from 2.4, to avoid being used by others, no setting is made in the master

@jaime0815
Copy link
Contributor

we don't need to set setMetricTypeForMetaInfo for master?
The only risk is that the search request might fail during the upgrade from 2.3 to 2.5.

@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@xiaofan-luan xiaofan-luan merged commit 5247631 into milvus-io:master Sep 6, 2024
14 of 16 checks passed
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SimFG, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants