fix: fill the metric type field in the LoadMetaInfo object (milvus-io…

…#35962) - issue: milvus-io#35960 Signed-off-by: SimFG <[email protected]>
chyezh · Sep 11, 2024 · b352b1c · b352b1c
1 parent 20ba2e5
commit b352b1c
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 4 deletions.
diff --git a/internal/core/src/query/SearchOnSealed.cpp b/internal/core/src/query/SearchOnSealed.cpp
@@ -42,7 +42,8 @@ SearchOnSealedIndex(const Schema& schema,
     // Keep the field_indexing smart pointer, until all reference by raw dropped.
     auto field_indexing = record.get_field_indexing(field_id);
     AssertInfo(field_indexing->metric_type_ == search_info.metric_type_,
-               "Metric type of field index isn't the same with search info");
+               "Metric type of field index isn't the same with search info,"
+               "field index: {}, search info: {}", field_indexing->metric_type_, search_info.metric_type_);
 
     auto dataset = knowhere::GenDataSet(num_queries, dim, query_data);
     dataset->SetIsSparse(is_sparse);

diff --git a/internal/core/src/segcore/ConcurrentVector.h b/internal/core/src/segcore/ConcurrentVector.h
@@ -71,7 +71,7 @@ class ThreadSafeVector {
 
     int64_t
     size() const {
-        std::lock_guard lck(mutex_);
+        std::shared_lock lck(mutex_);
         return size_;
     }
 

diff --git a/internal/datanode/compaction/priority_queue_test.go b/internal/datanode/compaction/priority_queue_test.go
@@ -4,8 +4,9 @@ import (
 	"container/heap"
 	"testing"
 
-	"github.com/milvus-io/milvus/internal/storage"
 	"github.com/stretchr/testify/suite"
+
+	"github.com/milvus-io/milvus/internal/storage"
 )
 
 type PriorityQueueSuite struct {

diff --git a/internal/datanode/compaction/segment_writer.go b/internal/datanode/compaction/segment_writer.go
@@ -8,6 +8,7 @@ import (
 	"context"
 	"math"
 
+	"github.com/samber/lo"
 	"go.uber.org/atomic"
 	"go.uber.org/zap"
 
@@ -21,7 +22,6 @@ import (
 	"github.com/milvus-io/milvus/pkg/log"
 	"github.com/milvus-io/milvus/pkg/util/paramtable"
 	"github.com/milvus-io/milvus/pkg/util/typeutil"
-	"github.com/samber/lo"
 )
 
 // Not concurrent safe.