Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [hotfix-2.4] fill the metric type field in the LoadMetaInfo object #35964

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Sep 4, 2024
@czs007
Copy link
Collaborator

czs007 commented Sep 4, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, SimFG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.95%. Comparing base (b2f0290) to head (b863082).
Report is 1 commits behind head on hotfix-2.4.10.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           hotfix-2.4.10   #35964      +/-   ##
=================================================
- Coverage          71.98%   71.95%   -0.03%     
=================================================
  Files               1056     1056              
  Lines             139304   139312       +8     
=================================================
- Hits              100274   100240      -34     
- Misses             34750    34779      +29     
- Partials            4280     4293      +13     
Files with missing lines Coverage Δ
internal/core/src/query/SearchOnSealed.cpp 0.00% <ø> (ø)
internal/core/src/segcore/ConcurrentVector.h 88.54% <ø> (ø)
internal/querycoordv2/task/executor.go 79.79% <100.00%> (-1.34%) ⬇️

... and 33 files with indirect coverage changes

@sre-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@xiaofan-luan xiaofan-luan merged commit b1ebac7 into milvus-io:hotfix-2.4.10 Sep 4, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants