Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: offset in not correctly used in HybridSaerch #36243

Open
1 task done
czs007 opened this issue Sep 13, 2024 · 1 comment
Open
1 task done

[Bug]: offset in not correctly used in HybridSaerch #36243

czs007 opened this issue Sep 13, 2024 · 1 comment
Assignees
@czs007
Labels
kind/bug Issues or changes related a bug needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. stale indicates no udpates for 30 days

Comments

@czs007
Copy link
Collaborator

czs007 commented Sep 13, 2024 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues

Environment

- Milvus version: master/2.4
- Deployment mode(standalone or cluster):
- MQ type(rocksmq, pulsar or kafka):    
- SDK version(e.g. pymilvus v2.0.0rc2):
- OS(Ubuntu or CentOS): 
- CPU/Memory: 
- GPU: 
- Others:

Current Behavior

Return an empty result if the offset and limit are identical.

hybrid_res = hello_milvus.hybrid_search(req_list, WeightedRanker(*weights), default_limit, output_fields=["random"], offset=default_limit)

hybrid_res is empty.

Expected Behavior

It should return a total of limit results.

Steps To Reproduce

No response

Milvus Log

No response

Anything else?

No response
@czs007 czs007 added kind/bug Issues or changes related a bug needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 13, 2024
@czs007 czs007 self-assigned this Sep 13, 2024
This was referenced Sep 13, 2024
Merged
Merged
sre-ci-robot pushed a commit that referenced this issue Sep 13, 2024
@czs007
fix: Fix improper use of offset in HybridSearch (#36244)
9d8d332 
issue :#36243

Signed-off-by: zhenshan.cao <[email protected]>
sre-ci-robot pushed a commit that referenced this issue Sep 13, 2024
@czs007
fix: Fix improper use of offset in HybridSearch (#36253)
34e5f99 
pr : #36244
issue : #36243

Signed-off-by: zhenshan.cao <[email protected]>
This was referenced Sep 14, 2024
Merged
Merged
czs007 added a commit that referenced this issue Sep 15, 2024
@czs007
fix: keep inner topK to avoid exceeding efSearch (#36287)
2bc454b 
issue :#36243
pr : #36284

Signed-off-by: zhenshan.cao <[email protected]>
czs007 added a commit that referenced this issue Sep 16, 2024
@czs007
fix: keep inner topK to avoid exceeding efSearch (#36284)
dcd904d 
issue: ##36243

Signed-off-by: zhenshan.cao <[email protected]>
@stale Stale
Copy link

stale bot commented Nov 9, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@czs007 czs007

Labels
kind/bug Issues or changes related a bug needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. stale indicates no udpates for 30 days
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@czs007