Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix improper use of offset in HybridSearch #36253

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

czs007
Copy link
Collaborator

@czs007 czs007 commented Sep 13, 2024

pr : #36244
issue : #36243

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. approved labels Sep 13, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug ci-passed labels Sep 13, 2024
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 79.06977% with 9 lines in your changes missing coverage. Please review.

Project coverage is 71.85%. Comparing base (16daf91) to head (7812173).
Report is 3 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/proxy/search_util.go 77.77% 8 Missing ⚠️
internal/proxy/task_search.go 85.71% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #36253      +/-   ##
==========================================
- Coverage   71.90%   71.85%   -0.06%     
==========================================
  Files        1060     1060              
  Lines      139553   139567      +14     
==========================================
- Hits       100349   100286      -63     
- Misses      34918    34984      +66     
- Partials     4286     4297      +11     
Files with missing lines Coverage Δ
internal/proxy/task_search.go 76.86% <85.71%> (-0.05%) ⬇️
internal/proxy/search_util.go 82.77% <77.77%> (-1.85%) ⬇️

... and 32 files with indirect coverage changes

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 34e5f99 into milvus-io:2.4 Sep 13, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants