fix: keep inner topK to avoid exceeding efSearch (#36287)

issue :#36243 pr : #36284 Signed-off-by: zhenshan.cao <[email protected]>
milvus-io · Sep 15, 2024 · 2bc454b · 2bc454b
1 parent 2df9309
commit 2bc454b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/internal/proxy/search_util.go b/internal/proxy/search_util.go
@@ -70,11 +70,7 @@ func parseSearchInfo(searchParamsPair []*commonpb.KeyValuePair, schema *schemapb
 			}
 			topK = externalLimit
 		} else {
-			if topKInParam < externalLimit {
-				topK = externalLimit
-			} else {
-				topK = topKInParam
-			}
+			topK = topKInParam
 		}
 	}
 

diff --git a/internal/proxy/task_search_test.go b/internal/proxy/task_search_test.go
@@ -1995,7 +1995,7 @@ func TestTaskSearch_parseSearchInfo(t *testing.T) {
 		info, offset, err := parseSearchInfo(offsetParam, nil, rank)
 		assert.NoError(t, err)
 		assert.NotNil(t, info)
-		assert.Equal(t, externalLimit, info.GetTopk())
+		assert.Equal(t, int64(10), info.GetTopk())
 		assert.Equal(t, int64(0), offset)
 	})