Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Reduce proxy CPU usage under high traffic payload #36102

Open
1 task done
congqixia opened this issue Sep 9, 2024 · 1 comment
Open
1 task done

[Enhancement]: Reduce proxy CPU usage under high traffic payload #36102

congqixia opened this issue Sep 9, 2024 · 1 comment
Assignees
Labels
kind/enhancement Issues or changes related to enhancement stale indicates no udpates for 30 days

Comments

@congqixia
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

What would you like to be added?

Proxy costs lots of CPU and could be the bottleneck under high read payload
We need to reduce the unwanted CPU usage such as calculating request/response size, transforming response format etc.

Why is this needed?

Reducing unneeded CPU cost could use less proxies supporting high read payload

Anything else?

No response

@congqixia congqixia added the kind/enhancement Issues or changes related to enhancement label Sep 9, 2024
congqixia added a commit to congqixia/milvus that referenced this issue Sep 9, 2024
Related to milvus-io#36102

This PR use newly added `grpcSizeStatsHandler` to
reduce calling `proto.Size` since the request &
response size info is recorded by grpc framework.

Signed-off-by: Congqi Xia <[email protected]>
sre-ci-robot pushed a commit that referenced this issue Sep 9, 2024
…36107)

Related to #36102

This PR use newly added `grpcSizeStatsHandler` to reduce calling
`proto.Size` since the request & response size info is recorded by grpc
framework.

Signed-off-by: Congqi Xia <[email protected]>
congqixia added a commit to congqixia/milvus that referenced this issue Sep 9, 2024
…ilvus-io#36107)

Related to milvus-io#36102

This PR use newly added `grpcSizeStatsHandler` to reduce calling
`proto.Size` since the request & response size info is recorded by grpc
framework.

Signed-off-by: Congqi Xia <[email protected]>
sre-ci-robot pushed a commit that referenced this issue Sep 10, 2024
…ics (#36107) (#36118)

Cherry-pick from master
pr: #36107 
Related to #36102

This PR use newly added `grpcSizeStatsHandler` to reduce calling
`proto.Size` since the request & response size info is recorded by grpc
framework.

Signed-off-by: Congqi Xia <[email protected]>
chyezh pushed a commit to chyezh/milvus that referenced this issue Sep 11, 2024
…ilvus-io#36107)

Related to milvus-io#36102

This PR use newly added `grpcSizeStatsHandler` to reduce calling
`proto.Size` since the request & response size info is recorded by grpc
framework.

Signed-off-by: Congqi Xia <[email protected]>
congqixia added a commit to congqixia/milvus that referenced this issue Oct 28, 2024
Related to milvus-io#36102

Previous PR milvus-io#36107 add grpc inteceptor to observe rpc
stats. Using same strategy, this pr add gin middleware
to observer restful v2 rpc stats.

Signed-off-by: Congqi Xia <[email protected]>
congqixia added a commit to congqixia/milvus that referenced this issue Oct 28, 2024
Related to milvus-io#36102

Previous PR milvus-io#36107 add grpc inteceptor to observe rpc
stats. Using same strategy, this pr add gin middleware
to observer restful v2 rpc stats.

Signed-off-by: Congqi Xia <[email protected]>
sre-ci-robot pushed a commit that referenced this issue Oct 29, 2024
…37224)

Cherry pick from master
pr: #37223
Related to #36102

Previous PR #36107 add grpc inteceptor to observe rpc stats. Using same
strategy, this pr add gin middleware to observer restful v2 rpc stats.

Signed-off-by: Congqi Xia <[email protected]>
sre-ci-robot pushed a commit that referenced this issue Oct 29, 2024
Related to #36102

Previous PR #36107 add grpc inteceptor to observe rpc stats. Using same
strategy, this pr add gin middleware to observer restful v2 rpc stats.

Signed-off-by: Congqi Xia <[email protected]>
congqixia added a commit to congqixia/milvus that referenced this issue Oct 29, 2024
…s-io#37223)

Related to milvus-io#36102

Previous PR milvus-io#36107 add grpc inteceptor to observe rpc stats. Using same
strategy, this pr add gin middleware to observer restful v2 rpc stats.

Signed-off-by: Congqi Xia <[email protected]>
sre-ci-robot pushed a commit that referenced this issue Oct 29, 2024
…37223) (#37240)

Cherry pick from master
pr: #37223
Related to #36102

Previous PR #36107 add grpc inteceptor to observe rpc stats. Using same
strategy, this pr add gin middleware to observer restful v2 rpc stats.

Signed-off-by: Congqi Xia <[email protected]>
Copy link

stale bot commented Nov 9, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Issues or changes related to enhancement stale indicates no udpates for 30 days
Projects
None yet
Development

No branches or pull requests

3 participants