enhance: [2.4] Use stats Handler to record request/response size metrics (#36107) #36118
Conversation
…ilvus-io#36107) Related to milvus-io#36102 This PR use newly added `grpcSizeStatsHandler` to reduce calling `proto.Size` since the request & response size info is recorded by grpc framework. Signed-off-by: Congqi Xia <[email protected]>
mergify
bot
added
dco-passed
|
@congqixia E2e jenkins job failed, comment |
|
/run-cpu-e2e |
|
@congqixia E2e jenkins job failed, comment |
|
/run-cpu-e2e |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.4 #36118 +/- ##
===========================================
+ Coverage 71.95% 85.00% +13.04%
===========================================
Files 1058 792 -266
Lines 139344 115131 -24213
===========================================
- Hits 100267 97867 -2400
+ Misses 34815 12985 -21830
- Partials 4262 4279 +17
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, xiaofan-luan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/run-cpu-e2e |
2 similar comments
|
/run-cpu-e2e |
|
/run-cpu-e2e |
Cherry-pick from master
pr: #36107
Related to #36102
This PR use newly added
grpcSizeStatsHandlerto reduce callingproto.Sizesince the request & response size info is recorded by grpc framework.