Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.4] Use middleware to observe restful v2 in/out rpc stats #37224

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

congqixia
Copy link
Contributor

Cherry pick from master
pr: #37223
Related to #36102

Previous PR #36107 add grpc inteceptor to observe rpc stats. Using same strategy, this pr add gin middleware to observer restful v2 rpc stats.

Related to milvus-io#36102

Previous PR milvus-io#36107 add grpc inteceptor to observe rpc
stats. Using same strategy, this pr add gin middleware
to observer restful v2 rpc stats.

Signed-off-by: Congqi Xia <[email protected]>
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved size/L Denotes a PR that changes 100-499 lines. labels Oct 28, 2024
@congqixia congqixia added this to the 2.4.14 milestone Oct 28, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement ci-passed labels Oct 28, 2024
@czs007
Copy link
Collaborator

czs007 commented Oct 29, 2024

/lgtm

@sre-ci-robot sre-ci-robot merged commit 4914752 into milvus-io:2.4 Oct 29, 2024
13 checks passed
@congqixia congqixia deleted the cp24/37223 branch October 29, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants