Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: pizzaboxer.Bloxstrap version 2.1.1 #102611

Conversation

pizzaboxer
Copy link
Contributor

@pizzaboxer pizzaboxer commented Apr 16, 2023

Pull request has been created with WinGet Releaser v2 🚀

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Apr 16, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello @pizzaboxer,

During installation testing, this application failed to install without user input. Did you forget to add Silent or SilentWithProgress switches?

This can also happen when a dependency is missing. You can test with https://github.com/microsoft/winget-pkgs#test-your-manifest.

Please investigate a fix and resubmit the Pull Request.

You may also try using the Windows Package Manager Manifest Creator to determine the proper installer type. If the installer type is MSIX, MSI, or a known installer technology like NullSoft, Inno, etc. the wingetcreate tool can detect them and the winget client will know what switches to pass. If it's a .exe installer of an unknown type, you will need to search to determine the proper switches for Silent and SilentWithProgress.

Template: msftbot/validationError/installation/unattended

@pizzaboxer
Copy link
Contributor Author

Requires .NET 6 desktop runtime as a dependency, see #92827 (comment).

image

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Apr 16, 2023
@stephengillie
Copy link
Collaborator

stephengillie commented Apr 17, 2023

x86 Automatic Validation failed with:
InstallationVerification-x86-Scope_Undefined-Locale_Undefined-ErrorScreenshot_20230416021120

x64 validation failed for the x64 architecture version of the dependency.

@stephengillie
Copy link
Collaborator

Even with the dependency preinstalled, the installer asks to install it.
image

@stephengillie stephengillie added Interactive-Only-Installer The package requires intearction to install. and removed Needs-Attention This work item needs to be reviewed by a member of the core team. labels Apr 17, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello @pizzaboxer,

This package appears to require user interaction to install.

This PR is blocked until support for interactive installer search filtering is implemented in:

Template: msftbot/blockingIssue/interactiveOnlyInstall

@stephengillie stephengillie removed their assignment Apr 17, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Blocking-Issue Manifest validation is blocked by a known issue. label Apr 17, 2023
@pizzaboxer
Copy link
Contributor Author

Even with the dependency preinstalled, the installer asks to install it. image

It doesn't really make sense that the installer asks to install it when it's preinstalled, since in my screenshot above I had the runtime preinstalled, and installing with Winget was completely fine. I even tried it in a VM to be sure, and it definitely works. Besides, the runtime check is done by .NET itself and not by me - if it failed to detect itself when it's really installed then I think there'd be a wider problem than just this. Can I see which version of the desktop runtime is installed?

image

@pizzaboxer
Copy link
Contributor Author

x86 Automatic Validation failed with: InstallationVerification-x86-Scope_Undefined-Locale_Undefined-ErrorScreenshot_20230416021120

x64 validation failed for the x64 architecture version of the dependency.

I noticed this myself when testing the install in a VM, but Winget doesn't even try to install the runtime even though it's explicitly specified as a dependency in the installer YAML for Microsoft.DotNet.DesktopRuntime.6. I know it was mentioned that dependency support is an experimental feature, but has it always been like this? I'm just wondering why this is only a problem now as nothing relating to this has changed between the previous version and now.

@sitiom
Copy link
Contributor

sitiom commented Apr 22, 2023

This happens every time. Is validation not installing the correct .NET Runtime arch?

@pizzaboxer
Copy link
Contributor Author

This happens every time. Is validation not installing the correct .NET Runtime arch?

See #103098 (comment), seems like it's being worked out.

@pizzaboxer pizzaboxer closed this Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocking-Issue Manifest validation is blocked by a known issue. Interactive-Only-Installer The package requires intearction to install. Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants