Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: pizzaboxer.Bloxstrap version 2.2.0 #103098

Conversation

pizzaboxer
Copy link
Contributor

@pizzaboxer pizzaboxer commented Apr 21, 2023

Pull request has been created with WinGet Releaser v2 🚀

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pizzaboxer
Copy link
Contributor Author

Defer this PR until #102611 has some resolution.

@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Apr 21, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello @pizzaboxer,

During installation testing, this application failed to install without user input. Did you forget to add Silent or SilentWithProgress switches?

This can also happen when a dependency is missing. You can test with https://github.com/microsoft/winget-pkgs#test-your-manifest.

Please investigate a fix and resubmit the Pull Request.

You may also try using the Windows Package Manager Manifest Creator to determine the proper installer type. If the installer type is MSIX, MSI, or a known installer technology like NullSoft, Inno, etc. the wingetcreate tool can detect them and the winget client will know what switches to pass. If it's a .exe installer of an unknown type, you will need to search to determine the proper switches for Silent and SilentWithProgress.

Template: msftbot/validationError/installation/unattended

@stephengillie
Copy link
Collaborator

@wingetbot waivers Add Validation-Unattended-Failed

@wingetbot wingetbot added the Waived-Validation-Unattended-Failed We've waived "Validation-Unsattended-Failed" it was likely a false detection. label Apr 21, 2023
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Apr 21, 2023
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Author-Feedback This needs a response from the author. label Apr 21, 2023
@stephengillie
Copy link
Collaborator

The issue in previous PRs is that the dependency needs to be x86, but the x64 version is installed by default. Not sure how to specify dependency architecture. Would it be possible to upgrade the package to use the x64 dependency?

@pizzaboxer
Copy link
Contributor Author

The issue in previous PRs is that the dependency needs to be x86, but the x64 version is installed by default. Not sure how to specify dependency architecture. Would it be possible to upgrade the package to use the x64 dependency?

Oh, I didn't realize that. The problem is that I publish both x64 and x86 versions of the application (for now), so I guess I could choose the option of not publishing x86 versions to Winget?

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Apr 21, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot enabled auto-merge (squash) April 21, 2023 20:03
@microsoft-github-policy-service
Copy link
Contributor

pizzaboxer,

The check-in policies require a moderator to approve PRs from the community.

Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission.

Template: msftbot/requiresApproval/moderator

@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Apr 21, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 253c8e4 into microsoft:master Apr 21, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello pizzaboxer,
Validation has completed.

Template: msftbot/validationCompleted

@stephengillie
Copy link
Collaborator

The issue in previous PRs is that the dependency needs to be x86, but the x64 version is installed by default. Not sure how to specify dependency architecture. Would it be possible to upgrade the package to use the x64 dependency?

Oh, I didn't realize that. The problem is that I publish both x64 and x86 versions of the application (for now), so I guess I could choose the option of not publishing x86 versions to Winget?

Thinking on this again, the x86 version needs to use the x86 dependency to work on 32-bit OSes. This is an issue with our validating, not your package. I'll work to solve this in my processes.

@pizzaboxer
Copy link
Contributor Author

pizzaboxer commented Apr 21, 2023

The issue in previous PRs is that the dependency needs to be x86, but the x64 version is installed by default. Not sure how to specify dependency architecture. Would it be possible to upgrade the package to use the x64 dependency?

Oh, I didn't realize that. The problem is that I publish both x64 and x86 versions of the application (for now), so I guess I could choose the option of not publishing x86 versions to Winget?

Thinking on this again, the x86 version needs to use the x86 dependency to work on 32-bit OSes. This is an issue with our validating, not your package. I'll work to solve this in my processes.

Thank you. I appreciate the response, though I wouldn't mind only publishing the x64 version since x86 usage is very small (about 4% according to GitHub releases), and it's due to be removed very soon anyway.

@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@pizzaboxer pizzaboxer deleted the pizzaboxer.Bloxstrap-2.2.0-1E5002EFEB2A07237E38D2B304B443D4 branch July 24, 2023 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Validation-Completed Validation passed Waived-Validation-Unattended-Failed We've waived "Validation-Unsattended-Failed" it was likely a false detection.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants