Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: pizzaboxer.Bloxstrap version 1.6.1 #92827

Merged

Conversation

sitiom
Copy link
Contributor

@sitiom sitiom commented Jan 3, 2023

An open-source, feature-packed alternative bootstrapper for Roblox.

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.2 schema?
Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@sitiom sitiom mentioned this pull request Jan 3, 2023
5 tasks
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Jan 3, 2023
@ghost ghost assigned sitiom Jan 3, 2023
@ghost
Copy link

ghost commented Jan 3, 2023

Hello @sitiom,

During installation testing, this application failed to install without user input. Did you forget to add Silent or SilentWithProgress switches?

This can also happen when a dependency is missing. You can test with https://github.com/microsoft/winget-pkgs#test-your-manifest.

Please investigate a fix and resubmit the Pull Request.

You may also try using the Windows Package Manager Manifest Creator to determine the proper installer type. If the installer type is MSIX, MSI, or a known installer technology like NullSoft, Inno, etc. the wingetcreate tool can detect them and the winget client will know what switches to pass. If it's a .exe installer of an unknown type, you will need to search to determine the proper switches for Silent and SilentWithProgress.

Template: msftbot/validationError/installation/unattended

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Jan 3, 2023
@sitiom sitiom force-pushed the pizzaboxer.Bloxstrap-1.6.1-971E0124A9C6EA branch from 171831a to 38ddbf2 Compare January 3, 2023 15:38
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@ghost ghost removed Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. Needs-Author-Feedback This needs a response from the author. labels Jan 3, 2023
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Jan 3, 2023
@ghost ghost assigned sitiom Jan 3, 2023
@ghost
Copy link

ghost commented Jan 3, 2023

Hello @sitiom,

During installation testing, this application failed to install without user input. Did you forget to add Silent or SilentWithProgress switches?

This can also happen when a dependency is missing. You can test with https://github.com/microsoft/winget-pkgs#test-your-manifest.

Please investigate a fix and resubmit the Pull Request.

You may also try using the Windows Package Manager Manifest Creator to determine the proper installer type. If the installer type is MSIX, MSI, or a known installer technology like NullSoft, Inno, etc. the wingetcreate tool can detect them and the winget client will know what switches to pass. If it's a .exe installer of an unknown type, you will need to search to determine the proper switches for Silent and SilentWithProgress.

Template: msftbot/validationError/installation/unattended

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Jan 3, 2023
@Trenly
Copy link
Contributor

Trenly commented Jan 3, 2023

Blocked due to dependency support being an experimental feature

@msftbot dependencies

@ghost ghost added Dependencies Blocking-Issue Manifest validation is blocked by a known issue. labels Jan 3, 2023
@stephengillie
Copy link
Collaborator

@wingetbot waivers Add Validation-Unattended-Failed

@wingetbot wingetbot added the Waived-Validation-Unattended-Failed We've waived "Validation-Unsattended-Failed" it was likely a false detection. label Jan 3, 2023
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@ghost ghost removed Blocking-Issue Manifest validation is blocked by a known issue. Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. Needs-Author-Feedback This needs a response from the author. labels Jan 3, 2023
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Jan 3, 2023
@ghost
Copy link

ghost commented Jan 3, 2023

Hello @wingetbot!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost
Copy link

ghost commented Jan 3, 2023

sitiom,

The check-in policies require a moderator to approve PRs from the community.

Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission.

Template: msftbot/requiresApproval/moderator

@ghost ghost added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jan 4, 2023
@ghost ghost merged commit d2dc882 into microsoft:master Jan 4, 2023
@ghost
Copy link

ghost commented Jan 4, 2023

Hello sitiom,
Validation has completed.

Template: msftbot/validationCompleted

@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Dependencies Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Validation-Completed Validation passed Waived-Validation-Unattended-Failed We've waived "Validation-Unsattended-Failed" it was likely a false detection.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants