-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Julia as Shell type #225083
Add Julia as Shell type #225083
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good to me!!!
FYI @davidanthoff, @pfitzseb |
Oh, great to see! Is the shell type set based on the executable name (i.e. |
@pfitzseb yes, but not necessarily the path that's passed in. There's some logic that inspects the process tree of the terminal to find the inner shell path/process name: vscode/src/vs/platform/terminal/node/terminalProcess.ts Lines 407 to 416 in 559107b
vscode/src/vs/platform/terminal/node/windowsShellHelper.ts Lines 115 to 134 in 559107b
The idea being, if you launch bash inside pwsh, it should correctly get changed to bash. |
Adding Julia as Shell type.
Resolves: #224325
Will handle adding NuShell in separate PR
Will handle separating out pwsh, python, julia into GenericShellType Enum in separate PR.