Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Julia as Shell type #225083

Merged
merged 6 commits into from
Aug 9, 2024
Merged

Add Julia as Shell type #225083

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8a82ce7
Start adding Julia as Shell type
anthonykim1 Aug 7, 2024
73a5010
remove unncessary
anthonykim1 Aug 7, 2024
b731bae
dont touch original
anthonykim1 Aug 7, 2024
354040b
add julia.exe to windowsShellHelper & clean up
anthonykim1 Aug 8, 2024
497e93f
remove completed TODO
anthonykim1 Aug 8, 2024
9e3a5b2
format
anthonykim1 Aug 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/vs/platform/terminal/common/terminal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,14 +135,16 @@ export const enum PosixShellType {
Csh = 'csh',
Ksh = 'ksh',
Zsh = 'zsh',
Python = 'python'
Python = 'python',
Julia = 'julia'
}
export const enum WindowsShellType {
CommandPrompt = 'cmd',
PowerShell = 'pwsh',
Wsl = 'wsl',
GitBash = 'gitbash',
Python = 'python'
Python = 'python',
Julia = 'julia'
}
export type TerminalShellType = PosixShellType | WindowsShellType;

Expand Down
3 changes: 3 additions & 0 deletions src/vs/platform/terminal/node/terminalProcess.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ const posixShellTypeMap = new Map<string, PosixShellType>([
['sh', PosixShellType.Sh],
['pwsh', PosixShellType.PowerShell],
['python', PosixShellType.Python],
['julia', PosixShellType.Julia],
['zsh', PosixShellType.Zsh]
]);

Expand Down Expand Up @@ -411,6 +412,8 @@ export class TerminalProcess extends Disposable implements ITerminalChildProcess

if (sanitizedTitle.toLowerCase().startsWith('python')) {
this._onDidChangeProperty.fire({ type: ProcessPropertyType.ShellType, value: PosixShellType.Python });
} else if (sanitizedTitle.toLowerCase().startsWith('julia')) {
this._onDidChangeProperty.fire({ type: ProcessPropertyType.ShellType, value: PosixShellType.Julia });
} else {
this._onDidChangeProperty.fire({ type: ProcessPropertyType.ShellType, value: posixShellTypeMap.get(sanitizedTitle) });
}
Expand Down
2 changes: 2 additions & 0 deletions src/vs/platform/terminal/node/windowsShellHelper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,8 @@ export class WindowsShellHelper extends Disposable implements IWindowsShellHelpe
case 'bash.exe':
case 'git-cmd.exe':
return WindowsShellType.GitBash;
case 'julia.exe:':
return WindowsShellType.Julia;
case 'wsl.exe':
case 'ubuntu.exe':
case 'ubuntu1804.exe':
Expand Down
Loading