Add Julia as Shell type (#225083)

* Start adding Julia as Shell type * remove unncessary * dont touch original * add julia.exe to windowsShellHelper & clean up * remove completed TODO * format
microsoft · Aug 9, 2024 · 9b803e9 · 9b803e9
1 parent 6aabf62
commit 9b803e9
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/src/vs/platform/terminal/common/terminal.ts b/src/vs/platform/terminal/common/terminal.ts
@@ -135,14 +135,16 @@ export const enum PosixShellType {
 	Csh = 'csh',
 	Ksh = 'ksh',
 	Zsh = 'zsh',
-	Python = 'python'
+	Python = 'python',
+	Julia = 'julia'
 }
 export const enum WindowsShellType {
 	CommandPrompt = 'cmd',
 	PowerShell = 'pwsh',
 	Wsl = 'wsl',
 	GitBash = 'gitbash',
-	Python = 'python'
+	Python = 'python',
+	Julia = 'julia'
 }
 export type TerminalShellType = PosixShellType | WindowsShellType;
 

diff --git a/src/vs/platform/terminal/node/terminalProcess.ts b/src/vs/platform/terminal/node/terminalProcess.ts
@@ -74,6 +74,7 @@ const posixShellTypeMap = new Map<string, PosixShellType>([
 	['sh', PosixShellType.Sh],
 	['pwsh', PosixShellType.PowerShell],
 	['python', PosixShellType.Python],
+	['julia', PosixShellType.Julia],
 	['zsh', PosixShellType.Zsh]
 ]);
 
@@ -411,6 +412,8 @@ export class TerminalProcess extends Disposable implements ITerminalChildProcess
 
 		if (sanitizedTitle.toLowerCase().startsWith('python')) {
 			this._onDidChangeProperty.fire({ type: ProcessPropertyType.ShellType, value: PosixShellType.Python });
+		} else if (sanitizedTitle.toLowerCase().startsWith('julia')) {
+			this._onDidChangeProperty.fire({ type: ProcessPropertyType.ShellType, value: PosixShellType.Julia });
 		} else {
 			this._onDidChangeProperty.fire({ type: ProcessPropertyType.ShellType, value: posixShellTypeMap.get(sanitizedTitle) });
 		}

diff --git a/src/vs/platform/terminal/node/windowsShellHelper.ts b/src/vs/platform/terminal/node/windowsShellHelper.ts
@@ -143,6 +143,8 @@ export class WindowsShellHelper extends Disposable implements IWindowsShellHelpe
 			case 'bash.exe':
 			case 'git-cmd.exe':
 				return WindowsShellType.GitBash;
+			case 'julia.exe:':
+				return WindowsShellType.Julia;
 			case 'wsl.exe':
 			case 'ubuntu.exe':
 			case 'ubuntu1804.exe':