Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: snap package validation #127119

Closed
wants to merge 2 commits into from
Closed

fix: snap package validation #127119

wants to merge 2 commits into from

Conversation

deepak1556
Copy link
Collaborator

Fixes #127081

@deepak1556 deepak1556 self-assigned this Jun 24, 2021
@deepak1556 deepak1556 added this to the June 2021 milestone Jun 24, 2021
@deepak1556
Copy link
Collaborator Author

deepak1556 commented Jun 24, 2021

Build https://dev.azure.com/monacotools/Monaco/_build/results?buildId=124922&view=results

  • verify SNAP_ENFORCE_RESQUASHFS=1 snap-review <path-to>/code-insiders.snap
  • verify code-insiders --disable-namespace-sandbox

@deepak1556 deepak1556 requested a review from joaomoreno June 24, 2021 23:41
@deepak1556 deepak1556 marked this pull request as draft June 25, 2021 01:21
@deepak1556
Copy link
Collaborator Author

deepak1556 commented Jun 25, 2021

Since resquash test doesn't allow setuid bit for chrome-sandbox, if we need to pass the validation step then we cannot chmod 4755 in any of the lifecycle steps. Two options for snap package,

  1. Always disable sandbox but eventually we should change our confinement from classic for this to be safer.

  2. Disable setuid sandbox, so that app always default to user namespace sandbox which is available on all kernels >=3.10. For users unable to use namespace sandbox suggest workaround The SUID sandbox helper binary was found, but is not configured correctly electron/electron#17972 (comment) if they can configure.

/cc @bpasero thoughts ?

Currently deb and rpm supports the fallback setuid sandbox, we are only facing this issue with snap.

@deepak1556
Copy link
Collaborator Author

Another option, reach out to the snapcraft team and see if we can get an exception in the resquash test.

@bpasero
Copy link
Member

bpasero commented Jun 25, 2021

my 2 cents: if we cannot get sandbox to work with snap, we should stop releasing VSCode on snap and work with them to enable this.

Until we are there to enable sandbox, we can go back to no sandbox if that helps for snap only.

@deepak1556
Copy link
Collaborator Author

Agree, will disable sandbox in snap for now, opened #127140 to track next steps.

@deepak1556 deepak1556 closed this Jun 25, 2021
@deepak1556 deepak1556 deleted the robo/fix_snap_validation branch June 25, 2021 10:23
@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snap packages fail validation
2 participants