Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linux: enable setuid sandbox on snap #127140

Closed
2 tasks
deepak1556 opened this issue Jun 25, 2021 · 0 comments
Closed
2 tasks

Linux: enable setuid sandbox on snap #127140

deepak1556 opened this issue Jun 25, 2021 · 0 comments
Assignees
@deepak1556
Labels
engineering VS Code - Build / issue tracking / etc. sandbox Running VSCode in a node-free environment snap Issues related to the snap package

Comments

@deepak1556
Copy link
Collaborator

It was originally attempted in 92999c3 but the snap validation step does not allow changing permission bits to 4755 so we are running with sandbox disabled on snap.

  • Reach out to the snapcraft team and see how to fix the helper permission
  • Should snap only run with namespace sandbox if setuid helper cannot be fixed ?
@deepak1556 deepak1556 self-assigned this Jun 25, 2021
@deepak1556 deepak1556 added engineering VS Code - Build / issue tracking / etc. sandbox Running VSCode in a node-free environment snap Issues related to the snap package labels Jun 25, 2021
@deepak1556 deepak1556 added this to the On Deck milestone Jun 25, 2021
@deepak1556 deepak1556 mentioned this issue Jun 25, 2021
Closed
deepak1556 added a commit that referenced this issue Jun 25, 2021
@deepak1556
chore: disable sandbox on snap package
7eae810 
Fixes #127081
Refs #127140
@deepak1556 deepak1556 mentioned this issue Jul 13, 2021
Closed
1 task
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
@deepak1556
chore: disable sandbox on snap package
5b2263d 
Fixes microsoft#127081
Refs microsoft#127140
@joaomoreno joaomoreno assigned joaomoreno and unassigned deepak1556 Dec 12, 2022
@joaomoreno joaomoreno assigned deepak1556 and unassigned joaomoreno Mar 5, 2023
@deepak1556 deepak1556 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 12, 2023
@deepak1556 deepak1556 removed this from the On Deck milestone Dec 12, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@deepak1556 deepak1556

Labels
engineering VS Code - Build / issue tracking / etc. sandbox Running VSCode in a node-free environment snap Issues related to the snap package
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: enable browser-sandbox for snap microsoft/vscode
3 participants
@joaomoreno @deepak1556 @aiday-mar